Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web implementation #135

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

maRci002
Copy link

@maRci002 maRci002 commented Apr 3, 2023

closes #14

The scaling functionality behaves similarly to Android's scales. However, I can update the algorithm to use cropping if both maxWidth and maxHeight are present to match the behavior of iOS.

Running example on the web:

thumbnail.mp4

I have tested it with video_editor package:

video_editor.mp4

I have updated the plugin to use an endorsed federated plugin. You can find more information on this at https://medium.com/flutter/how-to-write-a-flutter-web-plugin-part-2-afdddb69ece6

As for publishing, here are the steps:

  • Ensure that the PR can be approved.
  • Remove the local path from pubspec.yaml. (I will update the PR.)
  • Merge the PR.
  • Publish the video_thumbnail_platform_interface as a new package.
  • Publish the video_thumbnail_web as a new package.
  • Release the new version of the video_thumbnail package.

@TillJohanndeiter
Copy link

TillJohanndeiter commented Aug 25, 2024

Nice work 👍

This PR contains the merge of this PR as an open todo. The PR is reviewed and has no conflict. Is there a reason why it's still open?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature/web]: Add Support for Flutter Web (sample provided)
3 participants