-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add snapshot retention etcd-s3-folder fix #10293
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandond
reviewed
Jun 4, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #10293 +/- ##
==========================================
- Coverage 47.89% 41.78% -6.12%
==========================================
Files 177 177
Lines 14792 14802 +10
==========================================
- Hits 7085 6185 -900
- Misses 6362 7439 +1077
+ Partials 1345 1178 -167
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
vitorsavian
force-pushed
the
snapshot-retention-fix
branch
2 times, most recently
from
June 5, 2024 01:07
f472e2d
to
28ef184
Compare
brandond
reviewed
Jun 5, 2024
brandond
reviewed
Jun 5, 2024
vitorsavian
force-pushed
the
snapshot-retention-fix
branch
3 times, most recently
from
June 5, 2024 17:13
e1cc3bf
to
d88db13
Compare
brandond
reviewed
Jun 5, 2024
brandond
requested changes
Jun 5, 2024
Signed-off-by: Vitor Savian <vitor.savian@suse.com>
vitorsavian
force-pushed
the
snapshot-retention-fix
branch
2 times, most recently
from
June 5, 2024 19:06
a238c92
to
5932b4c
Compare
brandond
previously approved these changes
Jun 5, 2024
👍🏻 I think that should do it... |
Signed-off-by: Vitor Savian <vitor.savian@suse.com>
vitorsavian
force-pushed
the
snapshot-retention-fix
branch
from
June 6, 2024 13:56
5932b4c
to
d285aa3
Compare
brandond
approved these changes
Jun 6, 2024
briandowns
approved these changes
Jun 6, 2024
This was referenced Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Types of Changes
Verification
etcd-s3-folder
flag and wait for the retention to happenTesting
Linked Issues
User-Facing Change
Further Comments