Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release-1.28] Add snapshot retention etcd-s3-folder fix #10315

Merged

Conversation

* Add snapshot retention folder fix

Signed-off-by: Vitor Savian <vitor.savian@suse.com>

* Add snapshot retention E2E test

Signed-off-by: Vitor Savian <vitor.savian@suse.com>

---------

Signed-off-by: Vitor Savian <vitor.savian@suse.com>
@vitorsavian vitorsavian requested a review from a team as a code owner June 6, 2024 21:20
Copy link

codecov bot commented Jun 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 35.67%. Comparing base (7de7adb) to head (3863a36).

Files Patch % Lines
pkg/etcd/s3.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.28   #10315      +/-   ##
================================================
- Coverage         42.68%   35.67%   -7.01%     
================================================
  Files               163      160       -3     
  Lines             16632    14052    -2580     
================================================
- Hits               7099     5013    -2086     
+ Misses             8274     8064     -210     
+ Partials           1259      975     -284     
Flag Coverage Δ
e2etests 35.67% <0.00%> (-10.25%) ⬇️
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vitorsavian vitorsavian merged commit afe4c37 into k3s-io:release-1.28 Jun 6, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants