Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more logs for rdma selector #226

Merged
merged 1 commit into from
Aug 7, 2020
Merged

Add more logs for rdma selector #226

merged 1 commit into from
Aug 7, 2020

Conversation

Mmduh-483
Copy link
Contributor

No description provided.

@Mmduh-483
Copy link
Contributor Author

@moshe010

zshi-redhat
zshi-redhat reviewed Apr 20, 2020
View reviewed changes
pkg/factory/factory.go Outdated Show resolved Hide resolved
@Mmduh-483 Mmduh-483 force-pushed the rdma-warning branch 3 times, most recently from 0f237f1 to 738fd4d Compare April 20, 2020 10:45
adrianchiris
adrianchiris reviewed Apr 23, 2020
View reviewed changes
pkg/netdevice/rdma.go Outdated Show resolved Hide resolved
@zshi-redhat zshi-redhat mentioned this pull request May 11, 2020
Closed
@amorenoz amorenoz mentioned this pull request May 20, 2020
Merged
@Mmduh-483
Copy link
Contributor Author

@zshi-redhat Any comments on the PR?

@zshi-redhat
Copy link
Collaborator

zshi-redhat commented Jun 15, 2020 •
edited
Loading

@zshi-redhat Any comments on the PR?

@Mmduh-483 when #231 get merged, it will be possible to prompt device specific warning message for rdma spec by checking resourceConfig.SelectorObj.IsRdma && rdmaSpec.isSupportRdma in NewPciNetDevice.

@adrianchiris
Copy link
Contributor

@Mmduh-483 seeing PR #231 got merged, this can now be reworked

@Mmduh-483
Copy link
Contributor Author

@zshi-redhat @adrianchiris Updated the PR

@Mmduh-483
Copy link
Contributor Author

@zshi-redhat @ahalim-intel Can you provide review

@moshe010 moshe010 mentioned this pull request Aug 6, 2020
Closed
@ahalimx86 ahalimx86 merged commit 3e4b443 into k8snetworkplumbingwg:master Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrianchiris adrianchiris adrianchiris approved these changes

@ahalimx86 ahalimx86 ahalimx86 approved these changes

@zshi-redhat zshi-redhat Awaiting requested review from zshi-redhat

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Mmduh-483 @zshi-redhat @adrianchiris @ahalimx86