Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

supports multi-arch image manifest #457

Merged
merged 1 commit into from
Jan 10, 2023

Conversation

cyclinder
Copy link
Contributor

supports multi-arch image manifest

@coveralls
Copy link
Collaborator

coveralls commented Jan 3, 2023

Pull Request Test Coverage Report for Build 3827918309

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 80.0%

Totals Coverage Status
Change from base Build 3741356975: 0.0%
Covered Lines: 1684
Relevant Lines: 2105

💛 - Coveralls

Signed-off-by: cyclinder <qifeng.guo@daocloud.io>
@adrianchiris adrianchiris merged commit 626daeb into k8snetworkplumbingwg:master Jan 10, 2023
@cyclinder
Copy link
Contributor Author

cyclinder commented Jan 10, 2023

Hi @Eoghan1232 , images build failed on amd64.

https://github.com/k8snetworkplumbingwg/sriov-network-device-plugin/actions/runs/3884003915/jobs/6625988380

It seems don't relate to these changes?

@Eoghan1232
Copy link
Collaborator

Hi @Eoghan1232 , images build failed on amd64.

https://github.com/k8snetworkplumbingwg/sriov-network-device-plugin/actions/runs/3884003915/jobs/6625988380

It seems don't relate to these changes?

Hi @cyclinder , yes that the build issue is related to #459 and a PR has been submitted to fix it #460
this fail is not due to your changes :)

once the PR is merged, the CICD should then pass

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants