Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating alpine version to fix docker image build #460

Closed

Conversation

Eoghan1232
Copy link
Collaborator

@Eoghan1232 Eoghan1232 commented Jan 9, 2023

Tagging base image to fix issue with latest gcc version in alpine 3.17
fixes #459

signed off: eoghan.russell@intel.com

@coveralls
Copy link
Collaborator

coveralls commented Jan 9, 2023

Pull Request Test Coverage Report for Build 3874152850

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 80.0%

Totals Coverage Status
Change from base Build 3866251323: 0.0%
Covered Lines: 1684
Relevant Lines: 2105

💛 - Coveralls

@Eoghan1232
Copy link
Collaborator Author

@adrianchiris @SchSeba

@SchSeba
Copy link
Collaborator

SchSeba commented Jan 9, 2023

Hi @Eoghan1232 thanks for the PR.
question do you know when intel will release a new ddptool or do we need to push on this #387 to maintain the same support but be able to upgrade the container image (to fix CVEs etc if/when needed)

@adrianchiris
Copy link
Contributor

adrianchiris commented Jan 9, 2023

@SchSeba it just the container that builds ddptool, final container base image is not affected.
did we ever have cve related to ddptool until today ?

i mean we essentialy recompile the same version, so we would only fix CVEs that are related to gcc bugs that introduce cve into compiled binaries.

that said, i do think its prefferable to have #387 and removed ddptool dependency from the project :)

update: just noticed we also build sriov dp in that image so maybe we could split build of ddp to its own image.
if we expect ddptool to be updated soon then maybe no need to bother with that.

@Eoghan1232
Copy link
Collaborator Author

question do you know when intel will release a new ddptool or do we need to push on this #387 to maintain the same support but be able to upgrade the container image (to fix CVEs etc if/when needed)

I raised the build issue internally, the team over ddptool could reproduce and are planning a fix in their next release for this.
So we will be able to update the alpine version once that is complete

that said, i do think its prefferable to have #387 and removed ddptool dependency from the project :)

I also like this idea :)

@SchSeba
Copy link
Collaborator

SchSeba commented Jan 16, 2023

Hi @Eoghan1232 can you please change the PR base on the discussion in the community meeting?

lets create another container with a static version just for the ddp build and leave the go build to use latest 1.18

@adrianchiris
Copy link
Contributor

@Eoghan1232 LMK if you want me to work on a fix for it (split container builds). we need to unblock CI

@adrianchiris
Copy link
Contributor

#463 addresses the comments in this PR. lets get it merged to unblock CI.

@SchSeba
Copy link
Collaborator

SchSeba commented Jan 23, 2023

This was fixed in #463

/close

@SchSeba SchSeba closed this Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sriov-network-device-plugin fails to build image
4 participants