-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating alpine version to fix docker image build #460
Conversation
Pull Request Test Coverage Report for Build 3874152850Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Hi @Eoghan1232 thanks for the PR. |
@SchSeba it just the container that builds ddptool, final container base image is not affected. i mean we essentialy recompile the same version, so we would only fix CVEs that are related to gcc bugs that introduce cve into compiled binaries. that said, i do think its prefferable to have #387 and removed ddptool dependency from the project :) update: just noticed we also build sriov dp in that image so maybe we could split build of ddp to its own image. |
I raised the build issue internally, the team over ddptool could reproduce and are planning a fix in their next release for this.
I also like this idea :) |
Hi @Eoghan1232 can you please change the PR base on the discussion in the community meeting? lets create another container with a static version just for the ddp build and leave the go build to use latest 1.18 |
@Eoghan1232 LMK if you want me to work on a fix for it (split container builds). we need to unblock CI |
#463 addresses the comments in this PR. lets get it merged to unblock CI. |
This was fixed in #463 /close |
Tagging base image to fix issue with latest gcc version in alpine 3.17
fixes #459
signed off: eoghan.russell@intel.com