Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kayrock based client doesn't handle tcp_closed #381

Closed
kennethito opened this issue Oct 31, 2019 · 2 comments · Fixed by #406
Closed

Kayrock based client doesn't handle tcp_closed #381

kennethito opened this issue Oct 31, 2019 · 2 comments · Fixed by #406

Comments

@kennethito
Copy link
Contributor

GenServer :pn_kafka_worker terminating
** (FunctionClauseError) no function clause matching in KafkaEx.New.Client.handle_info/2
    (kafka_ex) lib/kafka_ex/new/client.ex:187: KafkaEx.New.Client.handle_info({:tcp_closed, #Port<0.115858>}, %KafkaEx.New.Client.State{

This is happening periodically on what looks like a regular interval. I'm using master at https://github.com/kafkaex/kafka_ex/tree/c93ce47472bff36c41b7c2fa3920449ca342ef8f

It's not latest, but a brief inspection of latest doesn't look to be handling the message either?

@semarco
Copy link
Contributor

semarco commented Feb 25, 2020

@joshuawscott any hint to fix this issue? thank you!

@dantswain
Copy link
Collaborator

I've been observing this myself. AFAICT it's generally harmless - the broker appears to close the connection, which causes the GenServer to crash and restart. Arguably this is what should happen idiomatically for the Erlang VM as we would "fail fast" and not try to recover any potentially bad state due to the closed connection. It may be appropriate for it to not emit an error log, however. I'll be thinking about this.

dantswain added a commit that referenced this issue Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants