Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle closed sockets in new client #406

Merged
merged 3 commits into from
May 4, 2020
Merged

Handle closed sockets in new client #406

merged 3 commits into from
May 4, 2020

Conversation

dantswain
Copy link
Collaborator

This should close #381

joshuawscott
joshuawscott approved these changes Apr 30, 2020
View reviewed changes
Copy link
Member

@joshuawscott joshuawscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@dantswain dantswain merged commit 5a0707b into master May 4, 2020
@dantswain dantswain deleted the handle_tcp_close branch May 4, 2020 01:25
dantswain added a commit that referenced this pull request May 24, 2020
@dantswain
Fix socket close error
2bc5d90 
I think I introduced this error in #406 -

```
** (EXIT) an exception was raised:
        ** (UndefinedFunctionError) function nil.socket/0 is undefined
            nil.socket()
            (kafka_ex) lib/kafka_ex/new/client.ex:703: anonymous fn/2 in KafkaEx.New.Client.close_broker_by_socket/2
            (kafka_ex) lib/kafka_ex/new/cluster_metadata.ex:228: anonymous fn/2 in KafkaEx.New.ClusterMetadata.update_brokers/2
            (elixir) lib/map.ex:216: Map.new_transform/3
            (kafka_ex) lib/kafka_ex/new/cluster_metadata.ex:227: KafkaEx.New.ClusterMetadata.update_brokers/2
            (kafka_ex) lib/kafka_ex/new/client/state.ex:76: KafkaEx.New.Client.State.update_brokers/2
            (kafka_ex) lib/kafka_ex/new/client.ex:184: KafkaEx.New.Client.handle_info/2
            (stdlib) gen_server.erl:637: :gen_server.try_dispatch/4
```
@dantswain dantswain mentioned this pull request May 24, 2020
Merged
@joshuawscott joshuawscott mentioned this pull request Jul 14, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbruggem jbruggem jbruggem approved these changes

@joshuawscott joshuawscott joshuawscott approved these changes

@bjhaid bjhaid Awaiting requested review from bjhaid

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Kayrock based client doesn't handle tcp_closed
3 participants
@dantswain @joshuawscott @jbruggem