respect LOCATION_FILTER_THRESHOLD config, adjust sf_thresh range from 0.0001 to 0.99 #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
before: you set LOCATION_FILTER_THRESHOLD in config, and it was not respected, instead the default value of 0.03 was used. after: first the config value is used, if the "--sf_thresh" is set, then this value is used, if no config value and no "--sf_thresh" value is set, the default (0.03) is used. TODO: use a method of argparse, to see whether "--sf_thresh" is set.
only between 0.0001 and 0.99 could the full species list be "accessed" through sf_thresh
bartman081523
changed the title
bartman081523
changed the title
|
Ok, thanks. Makes sense. Two quick questions:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before:
-you set LOCATION_FILTER_THRESHOLD in config, and it was not respected, instead the default value of 0.03 was used.
-only a part of the species list could be adressed with sf_thresh (between 0.01 to 0.99)
after:
-first the config value is used, if the "--sf_thresh" is set, then this value is used, if no config value and no "--sf_thresh" value is set, the default (0.03) is used.
-the full species list can be adressed with sf_thresh (0.0001 to 0.99)
TODO: use a method of argparse, to see whether "--sf_thresh" is set.