Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: README.md version when using a Dockerfile with combination of ENTRYPOINT and CMD section #51

Merged
merged 1 commit into from
Feb 22, 2023

Conversation

jrcoding
Copy link
Contributor

@jrcoding jrcoding commented Jul 23, 2022

Since using the combination of ENTRYPOINT and CMD section in Dockerfile we have to explicitly call the analyze.py script on the command line, because the first argument on the command line overwrites the default command analyze.py and will be taken as command instead as an option to analyze.py like i.e. --i input and therefore python throws an error instead of calling the analyze.py script with option --i input.

@jrcoding
Copy link
Contributor Author

jrcoding commented Jul 23, 2022

BTW: great work all this!

AFAIK the combination of ENTRYPOINT and CMD section in Dockerfile only makes sense if one needs the feature to overwrite the default command, specified by CMD, with a different one i.e. like analyze_test.py specified on the command line.
My impression is, that this is never the case here, right?
If I'm right, it may be better to to go back in Dockerfile to ENTRYPOINT [ "python3" , "./analyze.py" ] and leave README.md as it is?!

I've added PR #52 for convenience

@jrcoding jrcoding changed the title fix: version for Dockerfile with combined ENTRYPOINT and CMD section fix: version for a Dockerfile with combination of ENTRYPOINT and CMD section Jul 24, 2022
@jrcoding jrcoding changed the title fix: version for a Dockerfile with combination of ENTRYPOINT and CMD section fix: version when using a Dockerfile with combination of ENTRYPOINT and CMD section Jul 24, 2022
@jrcoding jrcoding changed the title fix: version when using a Dockerfile with combination of ENTRYPOINT and CMD section fix: README.md version when using a Dockerfile with combination of ENTRYPOINT and CMD section Jul 24, 2022
@tommy4st tommy4st merged commit 4b47142 into kahst:main Feb 22, 2023
@tommy4st
Copy link
Collaborator

The idea was that you could also start the server.py or gui.py using the same Dockerfile, so this was the best solution right now. We still should add some documentation for running server.py and gui.py with Docker.

@jrcoding jrcoding deleted the fix/readme-docker branch February 22, 2023 20:42
Josef-Haupt pushed a commit to Josef-Haupt/BirdNET-Analyzer that referenced this pull request Feb 24, 2024
fix: README.md version when using a Dockerfile with combination of ENTRYPOINT and CMD section
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants