fix: Dockerfile with ENTRYPOINT only section #52
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrcoding
changed the title
|
We opted for #52 because it's the way we intended it to be 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for convenience and alternatively to PR #51
AFAIK the combination of
ENTRYPOINTandCMDsection in Dockerfile only makes sense if one needs the feature to overwrite the default command, specified byCMD, with a different one i.e. something likeanalyze_test.pyspecified on the command line.My impression is, that this is never the case here, right?
If I'm right, it may be better to to go back in Dockerfile to
ENTRYPOINT [ "python3" , "./analyze.py" ]and leave README.md as it is?!