Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Semicolon after @charset should be optional #108

Closed
Keats opened this issue May 10, 2021 · 5 comments
Closed

Semicolon after @charset should be optional #108

Keats opened this issue May 10, 2021 · 5 comments

Comments

@Keats
Copy link

Keats commented May 10, 2021

From Bulma (current master)

(venv) ~/C/pulls $ ./rsass/target/release/rsass bulma/bulma.sass 
Parse error: Eof
  ,
2 | /*! bulma.io v0.9.2 | MIT License | github.com/jgthms/bulma */
  | ^
  '
  bulma/bulma.sass 2:1  root stylesheet
@kaj
Copy link
Owner

kaj commented May 11, 2021

Hm. That type of comment seems to be handled fine to me. Maybe the problem is a comment in that position?

Ah, yes. The problem is that there is no ; at the end of the @charset declaration on line 1. Yes, that should probably be optional.

@Keats
Copy link
Author

Keats commented May 11, 2021

Ah sorry, I should have noticed the missing ;

@kaj
Copy link
Owner

kaj commented May 11, 2021

No problem. That ; seems to be optional in dart sass, so I should probably be in rsass as well.

@kaj kaj changed the title Doesn't handle all comment types Semicolon after @charset should be optional May 11, 2021
@kaj
Copy link
Owner

kaj commented May 13, 2021

Looking closer, I notice that the bulma source files is in sass syntax, not scss. Despite the name, rsass don't actually support the sass indention-based syntax (yet), only scss. So I think I'll just close this after all.

@Keats
Copy link
Author

Keats commented May 13, 2021

Whoa I didn't realise anyone was still using the sass syntax. That's a bit annoying but oh well.

@kaj kaj closed this as completed May 13, 2021
kaj added a commit that referenced this issue Jun 20, 2021
@kaj
Release 0.22.0 - 2021-06-20
22f6146 
Progress: 3992 of 6180 tests passed in dart-sass compatibility mode.

* The `sass::Item::MixinCall` enum alternative was modified.
* Signature changes in `css::CallArgs` and `sass:CallArgs`,
  and new alternatives in `sass::ArgsError`.
* `css::Value` has a new variant `ArgList`.
* The `OrderMap::keys()` and `values()` functions now returns iterators,
  `OrderMap::remove(key)` now returns the removed value.

* Better handling of mixin call bodies, the `@content` item, and the
  `content_exists` function.  Fixes #112.
* `@import` exposes things `@forward`ed in the imported module.
* Many improvements in parameter passing to functions and mixins.  PR #113.
* Some more fixes regarding function calls and modules.
* Support the `keywords` function in `sass:meta`.
* Removed some debug printouts that was accidentally left in 0.21.0.
* Update sass-spec test suite to 2021-06-14.

Thanks to @Keats for reporting #112 and #108.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kaj @Keats