Rewrite much of argument handling. #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaj
force-pushed
the
rework-arguments
branch
10 times, most recently
from
9356fca
to
6f21a24
Compare
kaj
force-pushed
the
rework-arguments
branch
2 times, most recently
from
c14e7f8
to
41ec20a
Compare
Including special handling of splat in `if` arguments.
kaj
added a commit
that referenced
this pull request
Jun 20, 2021
Progress: 3992 of 6180 tests passed in dart-sass compatibility mode. * The `sass::Item::MixinCall` enum alternative was modified. * Signature changes in `css::CallArgs` and `sass:CallArgs`, and new alternatives in `sass::ArgsError`. * `css::Value` has a new variant `ArgList`. * The `OrderMap::keys()` and `values()` functions now returns iterators, `OrderMap::remove(key)` now returns the removed value. * Better handling of mixin call bodies, the `@content` item, and the `content_exists` function. Fixes #112. * `@import` exposes things `@forward`ed in the imported module. * Many improvements in parameter passing to functions and mixins. PR #113. * Some more fixes regarding function calls and modules. * Support the `keywords` function in `sass:meta`. * Removed some debug printouts that was accidentally left in 0.21.0. * Update sass-spec test suite to 2021-06-14. Thanks to @Keats for reporting #112 and #108.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.