Update to Firmware 7.25 #18
Conversation
src/main/java/com/github/kaklakariada/fritzbox/model/homeautomation/ColorControl.java
Outdated
Show resolved
Hide resolved
| private int last; | ||
|
|
||
| @Text | ||
| private String name; | ||
|
|
||
| public boolean isLast() { |
There was a problem hiding this comment.
Sorry for nit-picking. But if this returns an int, we should rename the getter.
| public boolean isLast() { | |
| public boolean getLast() { |
There was a problem hiding this comment.
According to the documentation (Page 2: "Bedeutung der Werte:") this should indicate the last user which then (from my point of view) is a boolean.
My poor XML skills didn't bring me to a solution where i could mark the field to be a boolean and the xml annotation would do the translation from 1 to true.
|
Please also add an entry to the Changelog. Previously i always did this myself, but you know better how to describe your changes :) |
| } | ||
|
|
||
| @Test | ||
| public void parseSessionInfo() throws IOException { |
There was a problem hiding this comment.
[Minor] With my from today PR I just introduced assertJ into the project. Maybe you want to have a look at those Assertion classes which allow fluent-API assertions. BR, Peter.
There was a problem hiding this comment.
Will have a look, but as rebase is not my favourite git command, i would update these tests with my next contribution.
There was a problem hiding this comment.
Rebasing ist not required. I also don't use it ;)
| @@ -7,7 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
| ## [1.4.0] - unreleased | |||
|
|
|||
| ### Added | |||
|
|
|||
| * [#18] Added new fields to be compatible with Fritz!OS 7.25 | |||
| private int last; | ||
|
|
||
| @Text | ||
| private String name; | ||
|
|
||
| public boolean isLast() { |
|
I just created a new release 1.4.0 and published it to Maven Central. It may take a while until it is available at https://repo1.maven.org/maven2/com/github/kaklakariada/fritzbox-java-api/ |
Update to latest firmware version.