Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IDEA-114 added homeautomation group support #19

Conversation

PeterJelitsch
Copy link
Contributor

added assertJ core as test support
added homeautomation models Group and GroupInfo
marked txBusy and fwVersion as non required, as those attributes are not supported by older Fritz!OS versions.
added PowerMeter.getPowerMilliWatt to provide the original metric values.
added Assertion classes for the model objects
added a test xml stream to tst older Fritz!Boxes

added assertJ core as test support
added homeautomation models Group and GroupInfo
marked txBusy and fwVersion as non required, as those attributes are not supported by older Fritz!OS versions.
added PowerMeter.getPowerMilliWatt to provide the original metric values.
added Assertion classes for the model objects
added a test xml stream to tst older Fritz!Boxes
@kaklakariada kaklakariada self-requested a review February 28, 2021 11:38
@kaklakariada kaklakariada self-assigned this Feb 28, 2021
Copy link
Owner

@kaklakariada kaklakariada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vielen Dank für Deinen Beitrag und die ausführlichen Tests!

Bitte füge noch einen Eintrag zum changelog hinzu.

@PeterJelitsch
Copy link
Contributor Author

Changelog updated. Dann harre ich mal der 1.4.0 Besten Dank für's Review und mergen.

@kaklakariada kaklakariada merged commit 6bdd3cb into kaklakariada:master Feb 28, 2021
@kaklakariada
Copy link
Owner

Es gibt noch einen offenen PR #18. Sobald der gemergt ist, baue ich das Release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants