fix(init): fix test-main.(js/coffee) generation #1346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `pathToModule` function sets a project up such that your spec directory must be within your src directory. This approach directly contradicts the example describing how to use RequireJS with Karma in the documentation. Fixes karma-runner#1120, fixes karma-runner#896
|
LGTM! |
|
@cironunes why you add function Thanks |
|
@maksimr, this is something @vojtajina wanted I think, but I don't know what the initial motivation was. See this commit and attached comments: a99c387 |
|
That commit also introduces changes that break IE8, which I plan on submitting a fix for in a separate PR. |
|
@freethejazz Thanks! LGTM |
maksimr
added a commit
that referenced
this pull request
Mar 17, 2015
fix(init): fix test-main.(js/coffee) generation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
pathToModulefunction sets a project up such that your specdirectory must be within your src directory. This approach directly
contradicts the example describing how to use RequireJS with Karma in
the documentation.
Fixes #1120, fixes #896