feat(init): generate test-main.(js/coffee) for RequireJS projects #897

cironunes · 2014-01-22T20:56:00Z

I am working on issue #896. It still needs a lot of improvements and even tests. I really appreciate any suggestions.

vojtajina · 2014-02-05T07:02:21Z

requirejs.config.tpl.js

@@ -0,0 +1,30 @@
+var tests = [];
+for (var file in window.__karma__.files) {
+  if (window.__karma__.files.hasOwnProperty(file)) {


Normalize the paths to "module" ids (without the *.js suffix, etc.) - otherwise RequireJS treats the test files as "scripts" which causes many troubles...

Same for CoffeeScript version...

I did not got it. Actually I just copied this from the docs. Could you explain?

See

karma/test/e2e/requirejs/main.js

Lines 4 to 6 in 258ecc6

var pathToModule = function(path) {

return path.replace(/^\/base\//, '').replace(/\.js$/, '');

};

Yeah, we should update the docs too...

vojtajina · 2014-02-05T07:11:20Z

This looks great!

Currently karma init asks you "do you wanna use require?". If you say so, then it asks two questions about "where are your source/test files" (these files won't be included) and "where is your test-main.js?" (these will be included). I think instead of the second question, it should ask "do you wanna generate test-main.js/coffee?" If you say so, it generates test-main.js and not even ask the "include" question. If you say no, then it should ask the "include question".

What do you think?

cironunes · 2014-02-05T16:42:54Z

Thanks for the feedback @vojtajina!

I really liked it! I'm going to implement it today later and come back to discuss more.

cironunes · 2014-02-10T01:50:35Z

I just put the questions that way you said. Now I'm trying to figure out how to test it.

cironunes · 2014-02-20T19:56:50Z

@vojtajina, just updated here, can you take a look?

I updated the docs also. 😄

vojtajina · 2014-03-09T23:08:43Z

lib/init.js

@@ -239,12 +249,23 @@ exports.init = function(config) {
  sm.process(questions, function(answers) {
    var cwd = process.cwd();
    var configFile = config.configFile || 'karma.conf.js';
+    var requirejsConfigFile = path.resolve(


I think we should generate the test-main.js file in the same folder as the karma.conf.js, rather than cwd.
What do you think?

vojtajina · 2014-03-09T23:28:35Z

@cironunes this is really good! I sent some more comments.

Can you also update the RequireJS docs to mention karma init? Because now, with your update, the whole thing will be much simpler.

I'm about to push 0.12 release and I would like to include this in, so let me know if you have time to work on it in the next couple of days, otherwise I'm happy to finish it.

Thanks a lot for this!

cironunes · 2014-03-09T23:46:37Z

@vojtajina cool!

I appreciate your feedback and I'm going to work on it.

I just updated the docs and the question + hint about the config file.

FYI I'm planning to squash commits before merge

- use the same path of karma.conf.js - include the file

cironunes · 2014-03-10T00:25:41Z

Missing two things that I still didn't figure out:

Add the test-main.js for last
Unit tests

vojtajina · 2014-03-10T05:02:38Z

Awesome. Do you need any help?

cironunes · 2014-03-10T17:37:43Z

Yes, any help would be nice!

Actually if you want to finish it would be good too. But if you want to just guide me, I can do that.

vojtajina · 2014-03-10T22:29:25Z

Wait, you already did the "add test-main.js", right?
I think this is good! I will just squash it into a single commit and merging...

cironunes · 2014-03-10T22:51:14Z

I already did, but it should be added for last, right? And the tests are failing. Actually I'm not sure if I wrote reasonable tests for that...

vojtajina · 2014-03-10T23:05:06Z

All right, I did subtle changes, fixed the tests, made regexp more flexible... here is my changes vojtajina@50df045

vojtajina · 2014-03-10T23:09:42Z

Ok, squashed and merged as 85900c9 and a99c387

Thanks a lot @cironunes !!!

cironunes · 2014-03-10T23:46:03Z

Pretty nice!

You're welcome and thank you for Karma! 😄

vojtajina reviewed Feb 5, 2014
View reviewed changes

feat(init): generate test-main.(js/coffee) for RequireJS projects

fae81eb

vojtajina reviewed Mar 9, 2014
View reviewed changes

vojtajina added this to the v0.12 milestone Mar 9, 2014

vojtajina self-assigned this Mar 9, 2014

cironunes added 2 commits March 9, 2014 16:41

docs(requirejs): normalize paths to RequireJS modules

81f7915

chore(init): better word for RequireJS test-main question

f927eeb

cironunes added 2 commits March 9, 2014 17:01

style(init): simplify condition for generateTestMain, better wording

e855d16

style(init): updates in the generatorTestMain

48a143d

- use the same path of karma.conf.js - include the file

vojtajina closed this Mar 10, 2014

cironunes deleted the requirejs/test-main branch March 10, 2014 23:45

freethejazz mentioned this pull request Feb 22, 2015

init should generate test-main.js for RequireJS projects #896

Closed

maksimr mentioned this pull request Mar 12, 2015

fix(init): fix test-main.(js/coffee) generation #1346

Merged

google-admin unassigned vojtajina Mar 26, 2015

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(init): generate test-main.(js/coffee) for RequireJS projects #897

feat(init): generate test-main.(js/coffee) for RequireJS projects #897

cironunes commented Jan 22, 2014

vojtajina Feb 5, 2014

cironunes Feb 10, 2014

vojtajina Feb 14, 2014

vojtajina commented Feb 5, 2014

cironunes commented Feb 5, 2014

cironunes commented Feb 10, 2014

cironunes commented Feb 20, 2014

vojtajina Mar 9, 2014

vojtajina commented Mar 9, 2014

cironunes commented Mar 9, 2014

cironunes commented Mar 10, 2014

vojtajina commented Mar 10, 2014

cironunes commented Mar 10, 2014

vojtajina commented Mar 10, 2014

cironunes commented Mar 10, 2014

vojtajina commented Mar 10, 2014

vojtajina commented Mar 10, 2014

cironunes commented Mar 10, 2014

	var pathToModule = function(path) {
	return path.replace(/^\/base\//, '').replace(/\.js$/, '');
	};

feat(init): generate test-main.(js/coffee) for RequireJS projects #897

feat(init): generate test-main.(js/coffee) for RequireJS projects #897

Conversation

cironunes commented Jan 22, 2014

vojtajina Feb 5, 2014

Choose a reason for hiding this comment

cironunes Feb 10, 2014

Choose a reason for hiding this comment

vojtajina Feb 14, 2014

Choose a reason for hiding this comment

vojtajina commented Feb 5, 2014

cironunes commented Feb 5, 2014

cironunes commented Feb 10, 2014

cironunes commented Feb 20, 2014

vojtajina Mar 9, 2014

Choose a reason for hiding this comment

vojtajina commented Mar 9, 2014

cironunes commented Mar 9, 2014

cironunes commented Mar 10, 2014

vojtajina commented Mar 10, 2014

cironunes commented Mar 10, 2014

vojtajina commented Mar 10, 2014

cironunes commented Mar 10, 2014

vojtajina commented Mar 10, 2014

vojtajina commented Mar 10, 2014

cironunes commented Mar 10, 2014