Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update node support to v7 #2571

Merged
merged 4 commits into from
Feb 17, 2017
Merged

Conversation

pedrotcaraujo
Copy link
Contributor

@pedrotcaraujo pedrotcaraujo commented Feb 16, 2017

I'm openning this to improve the node support to v7.

  • Update engine in package.json to support Node v7.
  • Update travis.yml to run env Node v7.
  • Update appveyor.yml to run env Node v7.
  • Update 01-installation.md adding Node v7.

It closes the issue #2559

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

@googlebot
Copy link

CLAs look good, thanks!

@joscha
Copy link

joscha commented Feb 17, 2017

cc @dignifiedquire via #2559

@dignifiedquire
Copy link
Member

Thank you :octocat:

@dignifiedquire dignifiedquire merged commit eb407ab into karma-runner:master Feb 17, 2017
@joscha
Copy link

joscha commented Feb 18, 2017

Is there any way we can get a . release for this change @dignifiedquire ? Our install currently fails because of engine-strict set to true on node 7

@dignifiedquire
Copy link
Member

I plan to do a release later tonight

@joscha
Copy link

joscha commented Feb 21, 2017

landed in 1.5.0 - thanks @dignifiedquire

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants