-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(deps): add support for node@8 #2757
Conversation
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
Thanks @pedrotcaraujo for providing the blueprint for upgrading the supported node version in your PR #2571. |
Try google CLA again. |
This doesn't help. The most important point of the @googlebot's comment is:
|
Would it be better to close this PR and submit a new one ensuring that my email is configured correctly? |
@kellyjensen it should be enough for you to amend the commit with the correct name & mail:
and then |
Thank you! I will try that. |
CLAs look good, thanks! |
Thanks to #2767, rebasing from the latest |
Yay CI passed! |
+1 this is blocking me from configuring npm with engine-strict enabled. |
Is there anything else I need to do? Just checking. |
Is there an update on this one? This is blocking the usage of |
Thank you |
Add support for nodejs v8.
Updated package.json, .travis.yml, appveyor.yml and installation docs.
Fixes #2754