Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deps): add support for node@8 #2757

Merged
merged 1 commit into from
Aug 15, 2017
Merged

feat(deps): add support for node@8 #2757

merged 1 commit into from
Aug 15, 2017

Conversation

kellyjensen
Copy link
Contributor

Add support for nodejs v8.

Updated package.json, .travis.yml, appveyor.yml and installation docs.

Fixes #2754

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@kellyjensen
Copy link
Contributor Author

Thanks @pedrotcaraujo for providing the blueprint for upgrading the supported node version in your PR #2571.

@kellyjensen kellyjensen changed the title feat: add support for node@8 feat(deps): add support for node@8 Jun 29, 2017
@kellyjensen
Copy link
Contributor Author

Try google CLA again.

@shinnn
Copy link

shinnn commented Jul 19, 2017

Try google CLA again.

This doesn't help. The most important point of the @googlebot's comment is:

If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)?

@kellyjensen
Copy link
Contributor Author

Would it be better to close this PR and submit a new one ensuring that my email is configured correctly?

@mgol
Copy link
Contributor

mgol commented Jul 19, 2017

@kellyjensen it should be enough for you to amend the commit with the correct name & mail:

git commit --amend --author="Your Name <your.email@example.com>"

and then git push --force.

@kellyjensen
Copy link
Contributor Author

Thank you! I will try that.

@googlebot
Copy link

CLAs look good, thanks!

@shinnn
Copy link

shinnn commented Jul 20, 2017

Thanks to #2767, rebasing from the latest master will probably fix all failing tests.

@kellyjensen
Copy link
Contributor Author

Yay CI passed!

@qswitcher
Copy link

+1 this is blocking me from configuring npm with engine-strict enabled.

@joscha joscha mentioned this pull request Jul 25, 2017
@kellyjensen
Copy link
Contributor Author

Is there anything else I need to do? Just checking.

@shaiksphere
Copy link

Is there an update on this one? This is blocking the usage of karma on the Node 8 based projects of ours.

@dignifiedquire dignifiedquire merged commit f3e5c7f into karma-runner:master Aug 15, 2017
@dignifiedquire
Copy link
Member

Thank you :octocat:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants