Fix annotations example #2194
Closed
Fix annotations example #2194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… chrome This fixes the region plugin as well as the annotations plugin.
osheroff
force-pushed
the
osheroff/fix_annotations_example
branch
from
2126981
to
c795df8
Compare
|
this also fixes the regions plugin example. |
What was specifically the issue? The build for this PR is now failing. |
check out the examples for region and annotations (and anything that includes trivia.js); they're failing under chrome with "wavesurfer" is already defined.
yeah, seems unlikely that this PR caused it but I'll see. |
|
babel/babel-eslint#487 is the same issue; class field declarations are throing a no-undef from eslint. I've spent 10 minutes now and that's my yak shaving budget for the day. Yours if you want it :) |
|
fixed in #2196 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi guys. Went to see if annotations was the solution to my problem.
It's not, but this fixes the public facing example.