Add Markers plugin #2196
Merged
Add Markers plugin #2196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… chrome This fixes the region plugin as well as the annotations plugin.
This adds pro-tools style markers to a waveform, for easy jumping to predefined points.
thijstriemstra
suggested changes
Feb 26, 2021
can you clarify what you mean by version marker? |
|
I've addressed all other issue besides the version marker |
see https://jsdoc.app/tags-since.html, I would put it in the new plugin class. The version nr can be 4.x.0 where x is current version + 1 |
|
issues addressed. |
sandiz
pushed a commit
to sandiz/wavesurfer.js
that referenced
this pull request
Sep 1, 2021
* change let to var to prevent 'wavesurfer is already defined' error in chrome This fixes the region plugin as well as the annotations plugin. * add "markers" plugin This adds pro-tools style markers to a waveform, for easy jumping to predefined points. * remove markers from zoom example * remove crashy event listener * clean up event handlers on destroy * add changelog entry for marker plugin * add @SInCE tag * fetch url format * add PR number
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a "markers" plugin to wavesurfer, very similar to what Pro Tools gives you. Just a way to easily jump around in a waveform.
Lots more customization options are possible, but I figured I'd wait for the community for ask for it.