Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support extra kubernetes manifests #395

Merged
merged 5 commits into from
May 26, 2023
Merged

feat: Support extra kubernetes manifests #395

merged 5 commits into from
May 26, 2023

Conversation

fboula
Copy link
Contributor

@fboula fboula commented Feb 17, 2023 •
edited
Loading

Added support for extra kubernetes manifest creation. Fixes #394

Checklist

@fboula fboula requested a review from a team as a code owner February 17, 2023 08:55
JorTurFer
JorTurFer reviewed Mar 7, 2023
View reviewed changes
keda/Chart.yaml Outdated Show resolved Hide resolved
JorTurFer
JorTurFer reviewed Mar 7, 2023
View reviewed changes
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good! Could you add any extra object to the test case? 🙏

What do you think about this feature @kedacore/keda-helm-contributors ?

@fboula fboula force-pushed the feat/extra-manifests branch 2 times, most recently from 225db39 to fd06f3a Compare March 13, 2023 09:01
tomkerkhove
tomkerkhove reviewed Mar 13, 2023
View reviewed changes
keda/Chart.yaml Outdated Show resolved Hide resolved
@JorTurFer
Copy link
Member

Could you check the e2e tests too? It seems that the extra manifests are applied before the others and that's why they are failing (because ClusterTriggerAuthentication isn't registered yet)

@fboula fboula force-pushed the feat/extra-manifests branch 2 times, most recently from b0f9633 to 767b9e3 Compare March 16, 2023 14:40
JorTurFer
JorTurFer reviewed Apr 5, 2023
View reviewed changes
keda/Chart.yaml Outdated Show resolved Hide resolved
@mkilchhofer
Copy link
Contributor

I also need this feature to be able to deploy NetworkPolicies :-) Is there something I could assist?

@JorTurFer
Copy link
Member

@fboula , any update ?

@fboula
feat: Support extra kubernetes manifests
f5f541c 
Signed-off-by: Florian Boulanger <fboulanger51@gmail.com>
@fboula
chore: add extra-objects to test case
5f823e8 
Signed-off-by: Florian Boulanger <fboulanger51@gmail.com>
@fboula fboula force-pushed the feat/extra-manifests branch 4 times, most recently from 67ec8a1 to 23a8470 Compare May 11, 2023 07:54
@fboula
fix: invalid api version
c38e72b 
Signed-off-by: Florian Boulanger <fboulanger51@gmail.com>
@fboula fboula force-pushed the feat/extra-manifests branch 4 times, most recently from 873b427 to dd0bf70 Compare May 11, 2023 08:55
@fboula
chore: add helm hook
04ad7ef 
Signed-off-by: Florian Boulanger <fboulanger51@gmail.com>
@mkilchhofer mkilchhofer mentioned this pull request May 11, 2023
Closed
@fboula
Copy link
Contributor Author

fboula commented May 11, 2023

@JorTurFer I added a post-install hook on the test case. It looks better, thanks for the hint.

@fboula
Copy link
Contributor Author

fboula commented May 22, 2023

@JorTurFer any updates ?

@JorTurFer
Copy link
Member

Thanks for the improvement ❤️

@JorTurFer JorTurFer merged commit 77f2a2f into kedacore:main May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zroubalik zroubalik zroubalik left review comments

@tomkerkhove tomkerkhove tomkerkhove left review comments

@mkilchhofer mkilchhofer mkilchhofer left review comments

@JorTurFer JorTurFer JorTurFer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extra objects manifests
5 participants
@fboula @JorTurFer @mkilchhofer @zroubalik @tomkerkhove