Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove and deprecate unused variables and correct queueDepth default in IBM MQ scaler #1445

Merged
merged 3 commits into from
Aug 20, 2024

Update content/docs/2.16/scalers/ibm-mq.md

1b54369
Select commit
Loading
Failed to load commit list.
Merged

Remove and deprecate unused variables and correct queueDepth default in IBM MQ scaler #1445

Update content/docs/2.16/scalers/ibm-mq.md
1b54369
Select commit
Loading
Failed to load commit list.
Task list completed / task-list-completed succeeded Aug 20, 2024 in 0s

1 / 1 tasks completed

All tasks have been completed

Details

Required Tasks

Task Status
The current documentation states that the default queueDepth is 5, while the code default is 20. The documentation will be updated to reflect the correct default value of 20, aligning it with the code. Incomplete
The queueManager parameter is currently checked to see if it's filled, but it's not used elsewhere in the code. This unused code is removed. The documentation is updated accordingly. Incomplete
The parameter tlsDisabled is set to DEPRECATED. All other scalers use the parameter unsafeSsl. To maintain consistency across the other scalers, the code related to tlsDisabled is set to deprecated, as unsafeSsl already handles this functionality. Incomplete
Finally, some minor adjustments to the documentation to keep the formatting the same. Incomplete
Commits are signed with Developer Certificate of Origin (DCO) Completed
Add your contribution to all applicable KEDA versions Incomplete
GitHub checks are passing Incomplete
Is the DCO check failing? Here is how you can fix DCO issues Incomplete
How to become a listed end-user or a listed commerical offering Incomplete
Our contribution guide Incomplete