-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce ScaledJob
& ScaledObject
#653
Comments
I have pretty much the same opinion on this, I have shared the same concerns when there was the initial discussion on including Jobs some time ago, so I incline to separate both types. I am looking at the Duck typing concept (which should allow us to scale any scalable resource), so I think we should stick to ScaledObject and just add ScaledJob, since we will be able to not scale just Deployments, but ReplicaSets and other CRDs that implements scale subresource, eg. Argo Rollouts as requested in #595 . I'll add more details on the Duck typing later in #591, once I have all data and full picture. |
That's also fine for me, only problem I have is that |
We should try to gather requirements and features that we would like to see from |
ScaledJob
& ScaledDeployment
ScaledJob
& ScaledObject
Changed the title to contain |
|
We've discussed this topic a few times before but I think we have reached a point where
ScaledObject
needs to be split inScaledJob
&ScaledDeployment
.While they share a lot of same functionality, I think they are different by nature:
These also have different scaling needs which tend to be confusing people or give unexpected results:
An example of this confusion is #652.
Next to that, it would make the CRDs a lot cleaner given the properties are all focused on one type rather than one or two, depending on the property.
Now I am curious to know what others think but it feels like we need a bigger seperation in this and that every trigger will need to define if they support jobs, deployments or both as they typically need different information (message count > X rather than total message count == instance count).
The text was updated successfully, but these errors were encountered: