-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial step towards v2 #731
Conversation
@@ -7,7 +7,7 @@ import ( | |||
|
|||
servicebus "github.com/Azure/azure-service-bus-go" | |||
|
|||
"github.com/Azure/azure-amqp-common-go/v2/auth" | |||
"github.com/Azure/azure-amqp-common-go/v3/auth" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
curious about the update. Is it intentional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to update as much dependencies to the latest versions as possible. This was brought by updating some of the Azure deps. I was forced to update this particular import due to changes in the api. We can try to revert this, if you think that it is a problem.
I will follow up with more PRs once this one gets into I didn't want to put all the changes into one PR, as it would be hard to review it. Once you are OK with this PR, let me know and I will push these commits into |
6f88267
to
baf002e
Compare
You are a hero! |
…re#732) Signed-off-by: ycabrer <43866176+ycabrer@users.noreply.github.com>
Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>
Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>
Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>
Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>
Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>
Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>
Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>
I am going to merge this one into |
Ok for me! |
Initial step towards v2.
This version should able to scale any Resource that implements
/scale
subresource, ie.Deployment
,StatefulSet
,ArgoRollout
etc. KEDA should be able to get secrets from container andTriggerAuthentication
- the same as previous version.Scaling of
Job
is not implemented yet.Instructions on how to try this version, please give it a try:
git clone git@github.com:zroubalik/keda.git -b v2 cd keda kubectl apply -f deploy/crds/keda.sh_scaledobjects_crd.yaml kubectl apply -f deploy/crds/keda.sh_scaledjob_crd.yaml kubectl apply -f deploy/crds/keda.sh_triggerauthentications_crd.yaml kubectl apply -f deploy/
Major changes
Fixes #703
Fixes #701
Fixes #552
Fixes #595
Fixes #497
Partial fix for #653