Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apiextensions.k8s.io/v1beta1 deprecation in 1.16 #701

Closed
alegmal opened this issue Mar 25, 2020 · 6 comments · Fixed by #1202
Closed

apiextensions.k8s.io/v1beta1 deprecation in 1.16 #701

alegmal opened this issue Mar 25, 2020 · 6 comments · Fixed by #1202
Assignees
Labels
breaking-change enhancement New feature or request
Milestone

Comments

@alegmal
Copy link

alegmal commented Mar 25, 2020

Currently KEDA uses apiextensions.k8s.io/v1beta1 in CustomResourceDefinition.

apiextensions.k8s.io/v1beta1 is going to be deprecated in favor of apiextensions.k8s.io/v1 in 1.16 according to this resource:
https://kubernetes.io/docs/tasks/access-kubernetes-api/custom-resources/custom-resource-definitions/

we are planing to migrate and wanted to check if support for v1 is planned.

@alegmal alegmal added the support All issues related to questions and supporting customers label Mar 25, 2020
@tomkerkhove tomkerkhove added enhancement New feature or request and removed support All issues related to questions and supporting customers labels Mar 26, 2020
@tomkerkhove
Copy link
Member

We should certainly move to apiextensions.k8s.io/v1 but that will most probably be for 2.0.

Thoughts @ahmelsayed @zroubalik?

@tomkerkhove
Copy link
Member

Which version removes apiextensions.k8s.io/v1beta1 @Cerberussian, do you know?

For now it's deprecated but it's still around so we have time (which doesn't mean we should wait) but just to know how soon it will go away, 3 versions?

@zroubalik
Copy link
Member

zroubalik commented Mar 26, 2020

If apiextensions.k8s.io/v1beta1 is going to be present in a next few releases, we don't need to rush and could keep this change for 2.0, to be consistent.

If we change it to v1 now, we will drop support on kubernetes < 1.16.0, we can currently run KEDA on > 1.13, so it could affect users with older kubernetes versions.

@zroubalik zroubalik added this to the v2.0 milestone Mar 26, 2020
@tomkerkhove
Copy link
Member

Agreed, v2.0 sounds good to me

@zroubalik
Copy link
Member

As discussed on #1160, I think that we can safely require k8s v1.16+ for KEDA. That means that we can move to apiextensions.k8s.io/v1.

Any objections?

@tomkerkhove
Copy link
Member

Looks like that was released only on September 18, 2019; but makes sense to me. Maybe we can discuss tomorrow in standup?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants