New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add pause metric in prometheus for scaledobject #5044

Closed

geoffrey1330 wants to merge 24 commits into kedacore:main from geoffrey1330:feat/pause-metric

Contributor

geoffrey1330 commented Oct 4, 2023 •

edited

Loading

Provide a description of what has been changed

Checklist

When introducing a new scaler, I agree with the scaling governance policy
I have verified that my change is according to the deprecations & breaking changes policy
Tests have been added
Changelog has been updated and is aligned with our changelog requirements
A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
A PR is opened to update the documentation on (repo) (if applicable)
Commits are signed with Developer Certificate of Origin (DCO - learn more)

Fixes #

Relates to #4430
Relates to kedacore/keda-docs#1111

geoffrey1330 requested a review from a team as a code owner

October 4, 2023 00:20

github-actions bot commented Oct 4, 2023

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

Add an entry in our changelog in alphabetical order and link related issue
Update the documentation, if needed
Add unit & e2e tests for your changes
GitHub checks are passing
Is the DCO check failing? Here is how you can fix DCO issues

Learn more about:

Our contribution guide

eladmotola and others added 24 commits

October 4, 2023 01:27


          one commit

5a9bfef

Signed-off-by: Elad Motola <eladmotola95@gmail.com>
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>


          fix scaledObjectPausedTemplate template

2eac1dd

Signed-off-by: Elad Motola <eladmotola95@gmail.com>

Signed-off-by: eladmotola <43670376+eladmotola@users.noreply.github.com>
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>


          fix metric name in tests

7e4926b

Signed-off-by: Elad Motola <eladmotola95@gmail.com>

Signed-off-by: eladmotola <43670376+eladmotola@users.noreply.github.com>
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>


          chore(deps): update actions/setup-python action to v4.6.0 (kedacore#4467

c4be5db

)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>


          Update prometheus_metrics_test.go (kedacore#4437)

ea94c82

Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>


          chore: Use default script to instal az-cli (kedacore#4475)

f4ad5c9

Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>


          chore: GCP - fix logger (kedacore#4482)

e2d7cde

Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>


          Increase sleeping time in testScalerErrors (prometheus_metrics_test.g…

a6e9e38

…o) (kedacore#4481)

Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>


          fix(e2e): uninstall KEDA properly (kedacore#4491)

ad89eba

Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>


          fix(e2e): fixed some issues with e2e tests (kedacore#4508)

d8964de

Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>


          chore: Add logic to scale out/in the AKS cluster on every e2e test ex…

2643de1

…ecution (kedacore#4456)

Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>


          chore: Include cluster autoscaling in changelog (kedacore#4509)

a049aa4

Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>


          fix(config/grafana): use range for HPA metrics (kedacore#4513)

1e4082f

Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>


          fix(e2e): Add again the path filter to ignore non e2e tests during th…

3f4e73d

…e execution (kedacore#4510)

Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>


          chore: bump azidentity sdk (kedacore#4504)

2e8e962

Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>


          chore: Generate build-tools in 1.20.4 (kedacore#4516)

ed19cec

Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>


          chore: bump go version (1.20) (kedacore#4518)

0edf21a

Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>


          chore: use new cluster names (kedacore#4522)

3a0f2a9

Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>


          fix: Update e2e tests after upgrade k8s 1.26 (kedacore#4526)

f185a18

Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>


          rewrite RecordScalerPaused function to use bool

cb37419

Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>

Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>


          rewrite RecordScalerPaused function to use bool

103a9ab

Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>


          rewrite RecordScalerPaused function to use bool

a0893d5

Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>


          rewrite RecordScalerPaused function to use bool

3631c95

Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>


          rewrite RecordScalerPaused function to use bool

ef0803d

Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>

geoffrey1330 force-pushed the feat/pause-metric branch from cdbe607 to ef0803d Compare

October 4, 2023 00:27

geoffrey1330 changed the title ~~Feat/pause metric~~ add pause metric in prometheus for scaledobject

Contributor Author

geoffrey1330 commented Oct 4, 2023

Hi @zroubalik Here is my own PR.
I have made all the fix requested from the previous PR #4446

geoffrey1330 closed this

geoffrey1330 deleted the feat/pause-metric branch

October 4, 2023 00:35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet