-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce MAINTAINERS.md #662
Conversation
Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>
Should this list equal to initial commiters from the proposal? Or should it contain the active maintainers? It will need some update if it the latter. WDYT @jeffhollan ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, next step is to create a GOVERNANCE.md that dictates how maintainers are added/removed
@caniszczyk Already ahead of you! see #663 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add Satish Ranjan from Microsoft as part of the Maintainers as well.
@anirudhgarg We already have 8 maintainers, I'm not sure how many we'd want to add? Don't get me wrong, but maybe good to just be a contributor and we can make a vote on promoting to maintainer later on? |
Yeah I think we're trying to "give credit" to initial maintainers and also reflect current ones. I suspect we should just make this list the current ones and will have to sort out how best to give credit to founding maintainers in another section. Making some suggested edits with that in mind |
MAINTAINERS.md
Outdated
| Aarthi Saravanakumar | [Aarthisk](https://github.com/Aarthisk) | Microsoft | | ||
| Yaron Schneider | [yaron2](https://github.com/yaron2) | Microsoft | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Aarthi Saravanakumar | [Aarthisk](https://github.com/Aarthisk) | Microsoft | | |
| Yaron Schneider | [yaron2](https://github.com/yaron2) | Microsoft | | |
| Satish Ranjan | [SatishRanjan](https://github.com/SatishRanjan) | Microsoft | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah per earlier conversations for this specific markdown we are going to try to keep to just the active maintainers. I think it does make sense to give credit to initial ones, potentially even another section in this? FWIW in the CNCF proposal I don't plan on changing that. This would be more a reference for folks needing insight in current day to day of KEDA. cncf/toc#383
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MAINTAINERS.md
Outdated
| Yaron Schneider | [yaron2](https://github.com/yaron2) | Microsoft | | ||
| Ahmed ElSayed | [ahmelsayed](https://github.com/ahmelsayed) | Microsoft | | ||
| Zbynek Roubalik | [zroubalik](https://github.com/zroubalik) | Red Hat | | ||
| Ben Browning | [bbrowning](https://github.com/bbrowning) | Red Hat | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Ben Browning | [bbrowning](https://github.com/bbrowning) | Red Hat | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is that ok for you @zroubalik?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Introduced alumni and added @bbrowning to that but will wait for @bbrowning or @zroubalik to agree on that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking good
Signed-off-by: Tom Kerkhove kerkhove.tom@gmail.com
Fixes #659