Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce MAINTAINERS.md #662

Merged
merged 2 commits into from
Mar 11, 2020
Merged

Conversation

tomkerkhove
Copy link
Member

Signed-off-by: Tom Kerkhove kerkhove.tom@gmail.com

Fixes #659

Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>
@zroubalik
Copy link
Member

zroubalik commented Mar 10, 2020

Should this list equal to initial commiters from the proposal? Or should it contain the active maintainers? It will need some update if it the latter.

WDYT @jeffhollan ?

Copy link
Contributor

@yaron2 yaron2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

@caniszczyk caniszczyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, next step is to create a GOVERNANCE.md that dictates how maintainers are added/removed

@tomkerkhove
Copy link
Member Author

@caniszczyk Already ahead of you! see #663

Copy link
Contributor

@anirudhgarg anirudhgarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add Satish Ranjan from Microsoft as part of the Maintainers as well.

@tomkerkhove
Copy link
Member Author

@anirudhgarg We already have 8 maintainers, I'm not sure how many we'd want to add?

Don't get me wrong, but maybe good to just be a contributor and we can make a vote on promoting to maintainer later on?

@jeffhollan
Copy link
Member

Yeah I think we're trying to "give credit" to initial maintainers and also reflect current ones. I suspect we should just make this list the current ones and will have to sort out how best to give credit to founding maintainers in another section. Making some suggested edits with that in mind

MAINTAINERS.md Outdated
Comment on lines 9 to 10
| Aarthi Saravanakumar | [Aarthisk](https://github.com/Aarthisk) | Microsoft |
| Yaron Schneider | [yaron2](https://github.com/yaron2) | Microsoft |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| Aarthi Saravanakumar | [Aarthisk](https://github.com/Aarthisk) | Microsoft |
| Yaron Schneider | [yaron2](https://github.com/yaron2) | Microsoft |
| Satish Ranjan | [SatishRanjan](https://github.com/SatishRanjan) | Microsoft |

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah per earlier conversations for this specific markdown we are going to try to keep to just the active maintainers. I think it does make sense to give credit to initial ones, potentially even another section in this? FWIW in the CNCF proposal I don't plan on changing that. This would be more a reference for folks needing insight in current day to day of KEDA. cncf/toc#383

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense to me, does that sound fair to you @yaron2 @Aarthisk ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Introduced alumni and added @yaron2 & @Aarthisk to that but will wait for @Aarthisk to agree on that.

MAINTAINERS.md Outdated
| Yaron Schneider | [yaron2](https://github.com/yaron2) | Microsoft |
| Ahmed ElSayed | [ahmelsayed](https://github.com/ahmelsayed) | Microsoft |
| Zbynek Roubalik | [zroubalik](https://github.com/zroubalik) | Red Hat |
| Ben Browning | [bbrowning](https://github.com/bbrowning) | Red Hat |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| Ben Browning | [bbrowning](https://github.com/bbrowning) | Red Hat |

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that ok for you @zroubalik?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Introduced alumni and added @bbrowning to that but will wait for @bbrowning or @zroubalik to agree on that.

Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good

@jeffhollan jeffhollan merged commit 3ee31aa into kedacore:master Mar 11, 2020
@tomkerkhove tomkerkhove deleted the maintainers branch April 2, 2020 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add list of MAINTAINERS
6 participants