Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚧 Provide proposal of KEDA governance #663

Closed
wants to merge 7 commits into from

Conversation

tomkerkhove
Copy link
Member

@tomkerkhove tomkerkhove commented Mar 10, 2020

Provide proposal of governance for KEDA project.

Adding 🚧 until all maintainers have aye'd.

Depends on #662
Relates to #660

@tomkerkhove tomkerkhove requested a review from Aarthisk as a code owner March 10, 2020 17:07
@tomkerkhove tomkerkhove changed the title Provide proposal of KEDA governance 🚧 Provide proposal of KEDA governance Mar 10, 2020
@caniszczyk
Copy link

This LGTM. You also may want to add a section on adding/removing projects.

For example, say you want to add something like https://github.com/kedacore/dashboard or a kedacore/utilities project or transfer a repo into kedacore from somewhere else, that should be voted upon by the existing maintainers, similar to adding a new maintainer.

@tomkerkhove tomkerkhove requested a review from yaron2 March 10, 2020 17:55
@tomkerkhove
Copy link
Member Author

@yaron2 PTAL, I've added project management governance proposal as per @caniszczyk his request

GOVERNANCE.md Show resolved Hide resolved
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tomkerkhove
Copy link
Member Author

Copy link
Contributor

@yaron2 yaron2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ahmelsayed ahmelsayed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too

@caniszczyk
Copy link

LGTM

Copy link

@caniszczyk caniszczyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 , with the DCO bot installed, you'll have to 'git commit -s' all commits in the future :)

@tomkerkhove tomkerkhove assigned Aarthisk and unassigned caniszczyk and ahmelsayed Mar 16, 2020
@caniszczyk
Copy link

'git commit --amend -s' and push -f it back and we can close this back

Copy link
Contributor

@bbrowning bbrowning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>
@tomkerkhove
Copy link
Member Author

That moment when you forget to sign off your commit and you mess up the whole PR

@tomkerkhove
Copy link
Member Author

Clean PR is available on #690

@tomkerkhove tomkerkhove deleted the governance branch November 19, 2020 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants