-
Notifications
You must be signed in to change notification settings - Fork 901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plan to improve ci/cd + automated release setup of kedro-plugins
#2333
Comments
Having There's no great answer for this, but I've seen pre-commit/pre-commit#466 (comment). Keep in mind that the pre-commit author also says that it's not really designed for monorepos (although it can be made to work). @noklam raised a good point:
Maybe it makes sense to just use something like tox to manage the way you run tests in something like this? |
In order to install the Kedro dependency correctly, we need to add |
I would be open to putting together a PoC with |
kedro-plugins
kedro-plugins
kedro-plugins
kedro-plugins
PrefaceThe below breakdown of challenges and solutions aims to:
Challenges
Proposal
|
Agree with the challenges but I would order them in reverse order.
I would add one more challenge:
|
As discussed in technical design on 15/2:
|
Potentially relevant for the automated release https://blog.pypi.org/posts/2023-04-20-introducing-trusted-publishers/ |
I think most of #2333 (comment) has already been done, except for kedro-org/kedro-plugins#512 |
Closing this because the CI/CD of |
Description
Following up on kedro-org/kedro-plugins#4
Currently
kedro-plugins
has one top levelMakefile
, each plugin has it's own.pre-commit-config.yaml
andpyproject.toml
. Look at whether it would be better for these configuration files to be unified or for each plugin to have it's own files.@AntonyMilneQB Raised a good question about whether the pre-commit hooks actually still work without the file being at the root of the repo.
For this issue come up with a plan to improve the setup:
The text was updated successfully, but these errors were encountered: