-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tox4 support #156
Comments
|
@AntoineD Thanks for the very quick reply! Maybe we'll stick to |
@AntoineD As part of my project's custom tox plugin, I have finished a tox4 plugin with conda support. I am happy to adjust it to make general and be part of this repository. I am not saying that it will immediately cover all features |
@tibortakacs Could you please create a PR so we can have a look? |
@AntoineD Of course, happy to. Due to other commitments, it will take some time, I try to make it in two weeks. |
@AntoineD I have been working on this right now. You can track the progress here: https://github.com/tibortakacs/tox-conda/tree/tox4 |
Please find the draft PR here: #163 The main purpose is to agree on the direction, and once there is a common agreement, this PR can be improved by updating the tests and hitting the module hard to find and fix bugs. I have tested with the basic functionalities, it works fine, but I am sure that there are use cases that this PR does not cover yet. Looking forward to your feedback. |
@gaborbernat Do you have any suggestion how we can move forward? It might be a good step to use the |
Sure, I think ultimately blocked this on the maintainer (not me) to take it up. |
Thank you, @gaborbernat. (The PR is automatically assigned to you, I thought you are the one to make decision in this regard.) I will wait for the maintainers' feedback. |
See tox-dev/tox-conda#156 for context.
Is there an update on tox-conda supporting tox4? |
Yes, please find the PR here: #163 You can use the merging branch for now, it works fully. I hope I can find time soon to finish off the PR, and merge it back to main. Any early feedback is highly appreciated. |
(There are too many things happening in #2230, so I'll open a couple of PRs to simplify it) - Bring tox config as close as possible to `tox 4`, but keep using `tox 3` until [`tox-conda` is compatible with `tox 4`](tox-dev/tox-conda#156). Ended up adding an explicit `'tox>=3.27,<4'` to the conda dev env instructions to get the right version, and remove/replace deprecated options from `tox.ini` - Bump `MACOSX_DEPLOYMENT_TARGET` to `11.0` consistently for maturin and CI. - Remove Python installation for Rust tests in CI (not used) - Clean up `flake.nix` and avoid `naersk`, prefer regular `nixpkgs` tooling now that NixOS/nixpkgs#230596 is merged and we can keep them in sync - Move `.ci/install_cargo.sh` into `cibuildwheel` configuration, set up extra tools needed for `bindgen`/`cbindgen` (libclang and env vars)
Will
tox-conda
supporttox4
? I see that there's atox-4
branch, but it's almost 100 commits behindmaster
/doesn't look maintained.The text was updated successfully, but these errors were encountered: