Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tox4 support #156

Open
deepyaman opened this issue Jan 2, 2023 · 12 comments
Open

tox4 support #156

deepyaman opened this issue Jan 2, 2023 · 12 comments
Assignees

Comments

@deepyaman
Copy link

Will tox-conda support tox4? I see that there's a tox-4 branch, but it's almost 100 commits behind master/doesn't look maintained.

@AntoineD
Copy link
Collaborator

AntoineD commented Jan 2, 2023

tox4 will be supported, but for now I cannot give a better estimation than during 2023...

@deepyaman
Copy link
Author

@AntoineD Thanks for the very quick reply! Maybe we'll stick to tox3 for the time being then, and keep an eye on this.

@tibortakacs
Copy link
Collaborator

@AntoineD As part of my project's custom tox plugin, I have finished a tox4 plugin with conda support. I am happy to adjust it to make general and be part of this repository. I am not saying that it will immediately cover all features tox-conda already has, but I believe it covers the main use cases and could be the foundation of further works for tox4 support. It uses conda run instead of activation, it creates a conda ToxEnv, so using only one plugin (register new tox env) hook was enough.
Would you consider this as a contribution in tox-conda?

@AntoineD
Copy link
Collaborator

AntoineD commented Feb 2, 2023

@tibortakacs Could you please create a PR so we can have a look?

@tibortakacs
Copy link
Collaborator

@AntoineD Of course, happy to. Due to other commitments, it will take some time, I try to make it in two weeks.

@tibortakacs
Copy link
Collaborator

@AntoineD I have been working on this right now. You can track the progress here: https://github.com/tibortakacs/tox-conda/tree/tox4
I hope I can create a draft PR this week that shows the basic design principles. This can be used as a base of further discussion and work.

@tibortakacs
Copy link
Collaborator

Please find the draft PR here: #163
(This is based on this branch: https://github.com/tibortakacs/tox-conda/tree/tox4)

The main purpose is to agree on the direction, and once there is a common agreement, this PR can be improved by updating the tests and hitting the module hard to find and fix bugs. I have tested with the basic functionalities, it works fine, but I am sure that there are use cases that this PR does not cover yet.

Looking forward to your feedback.

@tibortakacs
Copy link
Collaborator

@gaborbernat Do you have any suggestion how we can move forward? It might be a good step to use the tox4 branch, merge this in, and gradually do the improvements and testing. We can also create pre-release package using it.

@gaborbernat
Copy link
Member

Sure, I think ultimately blocked this on the maintainer (not me) to take it up.

@tibortakacs
Copy link
Collaborator

Thank you, @gaborbernat. (The PR is automatically assigned to you, I thought you are the one to make decision in this regard.) I will wait for the maintainers' feedback.

@millsks
Copy link

millsks commented Aug 8, 2023

Is there an update on tox-conda supporting tox4?

@tibortakacs
Copy link
Collaborator

tibortakacs commented Aug 8, 2023

Is there an update on tox-conda supporting tox4?

Yes, please find the PR here: #163

You can use the merging branch for now, it works fully. I hope I can find time soon to finish off the PR, and merge it back to main. Any early feedback is highly appreciated.

luizirber added a commit to sourmash-bio/sourmash that referenced this issue Aug 19, 2023
(There are too many things happening in #2230, so I'll open a couple of
PRs to simplify it)

- Bring tox config as close as possible to `tox 4`, but keep using `tox
3` until [`tox-conda` is compatible with `tox
4`](tox-dev/tox-conda#156). Ended up adding an
explicit `'tox>=3.27,<4'` to the conda dev env instructions to get the
right version, and remove/replace deprecated options from `tox.ini`
- Bump `MACOSX_DEPLOYMENT_TARGET` to `11.0` consistently for maturin and
CI.
- Remove Python installation for Rust tests in CI (not used)
- Clean up `flake.nix` and avoid `naersk`, prefer regular `nixpkgs`
tooling now that NixOS/nixpkgs#230596 is merged
and we can keep them in sync
- Move `.ci/install_cargo.sh` into `cibuildwheel` configuration, set up
extra tools needed for `bindgen`/`cbindgen` (libclang and env vars)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants