Fix for windows path issue #150
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jitendra Gundaniya <jitendra_gundaniya@mckinsey.com>
jitu5
added
bug
noklam
reviewed
Nov 11, 2024
| @@ -250,7 +250,7 @@ def _get_param_location(server: KedroLanguageServer, word: str) -> Optional[Loca | |||
| continue | |||
|
|
|||
| location = Location( | |||
| uri=f"file://{parameters_file.resolve().as_posix()}", | |||
| uri=parameters_file.resolve().as_uri(), | |||
There was a problem hiding this comment.
>>> path
PosixPath('C:\\Window\\sysm\\some_file.csv')
>>> path.resolve()
PosixPath('/Users/Nok_Lam_Chan/C:\\Window\\sysm\\some_file.csv')
>>> path.resolve().as_uri()
'file:///Users/Nok_Lam_Chan/C%3A%5CWindow%5Csysm%5Csome_file.csv'
TIL: Brilliant!
@noklam Yes I tested with select environment command to 'local', after changing, its now navigate to
|
rashidakanchwala
approved these changes
Nov 11, 2024
noklam
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #102
This pull request includes several updates to the
bundled/tool/lsp_server.pyfile, focusing on improving the way file URIs are resolved and refining the handling of pipeline files. The most important changes are as follows:Development notes
Updated the
Locationobject creation to use theas_uri()method for resolving file URIs in_get_param_location,_query_catalog, andreference_locationmethods.Refactored the
referencesmethod to usePath.read_text()for reading pipeline files, which includes handling potential I/O and Unicode errors.QA notes
Used Parallels Desktop Pro to test on Windows.
Gif (Windows)