Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for windows path issue #150

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix for windows path issue #150

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 15 additions & 11 deletions bundled/tool/lsp_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,7 +250,7 @@ def _get_param_location(server: KedroLanguageServer, word: str) -> Optional[Loca
continue

location = Location(
uri=f"file://{parameters_file.resolve().as_posix()}",
uri=parameters_file.resolve().as_uri(),
Copy link
Contributor

@noklam noklam Nov 11, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

>>> path
PosixPath('C:\\Window\\sysm\\some_file.csv')
>>> path.resolve()
PosixPath('/Users/Nok_Lam_Chan/C:\\Window\\sysm\\some_file.csv')
>>> path.resolve().as_uri()
'file:///Users/Nok_Lam_Chan/C%3A%5CWindow%5Csysm%5Csome_file.csv'

TIL: Brilliant!

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same! TIL. nice :)

range=Range(
start=Position(line=param_line_no - 1, character=0),
end=Position(
Expand Down Expand Up @@ -305,7 +305,7 @@ def _query_catalog(document, word=None):
if word in catalog_conf:
line = catalog_conf[word]["__line__"]
location = Location(
uri=f"file://{catalog_path}",
uri=catalog_path.resolve().as_uri(),
range=Range(
start=Position(line=line - 1, character=0),
end=Position(
Expand Down Expand Up @@ -342,7 +342,7 @@ def _query_catalog(document, word=None):

def reference_location(path, line):
location = Location(
uri=f"file://{path.resolve().as_posix()}",
uri=path.resolve().as_uri(),
range=Range(
start=Position(line=line, character=0),
end=Position(
Expand Down Expand Up @@ -375,19 +375,23 @@ def references(
from kedro.framework.project import PACKAGE_NAME

# Find pipelines module
importlib_resources.files(f"{PACKAGE_NAME}.pipelines")

pipelines_package = importlib_resources.files(f"{PACKAGE_NAME}.pipelines")

# Iterate on pipelines/**/*.py that fits both modular or flat pipeline structure.
result = []
pipeline_files = glob.glob(f"{pipelines_package}/**/*.py", recursive=True)
for pipeline_file in pipeline_files:
# Read the line number and match keywords naively
with open(pipeline_file) as f:
for i, line in enumerate(f):
for pipeline_file in glob.glob(f"{str(pipelines_package)}/**/*.py", recursive=True):
# Ensure the path is absolute
abs_pipeline_file = Path(pipeline_file).absolute()

try:
# Read the file using Path
content = abs_pipeline_file.read_text(encoding='utf-8').splitlines()
for i, line in enumerate(content):
if f'"{word}"' in line:
result.append((Path(pipeline_file), i))
result.append((abs_pipeline_file, i))
except (IOError, UnicodeDecodeError) as e:
log_for_lsp_debug(f"Error reading file {abs_pipeline_file}: {e}")
continue

locations = []
if result:
Expand Down