-
Notifications
You must be signed in to change notification settings - Fork 519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
npm install bcrypt@3.0.6 fails with node 12.3.0 #728
Comments
Are docker containers going to be released of this version soon? |
@robertIsaac make sure to run For me, bcrypt installs and works correctly on Mac and docker containers running |
yes it's different issue
|
@robertIsaac indeed. It appears that you don't have python installed, which is a requirement of the build process. Once pre-built packages are out for node 12 (see #721) you won't need to build from source; but until then, your source machine will need python to build bcrypt. If you want to discuss the python requirement, you might want to create a new issue, as I suspect @kelektiv will be closing this one shortly, since it is fixed. |
i think it's easier to drop bcrypt dependency than to install python once i dropped it, CI worked just fine |
I'm getting this node-pre-gyp WARN Using request for node-pre-gyp https download I'm using v12.3.1 |
I have a similar problem:
|
Bcrypt fails on Node v12 and there are related open issues for same kelektiv/node.bcrypt.js#728 and kelektiv/node.bcrypt.js#721. Let's wait for them to get fixed
Is this still a problem? Have you tried https://github.com/kelektiv/node.bcrypt.js/wiki/Installation-Instructions#microsoft-windows ? Can this issue be closed? |
Can confirm that the original issue was resolved from 12.3.1 onwards. |
issue still exits with node version 12.8.0
|
@robertIsaac your system seems to be missing Windows build tools including Python. Try the Windows Installation Instructions in the wiki: https://github.com/kelektiv/node.bcrypt.js/wiki/Installation-Instructions#microsoft-windows |
why do i need to do that now? |
@robertIsaac you upgraded to Node 12, which is too early in its lifecycle. bcrypt is not NodeJS code, it is in C and needs to be compiled into binaries so NodeJS can load it. The compilation is specific to the version of NodeJS. This is the case as one of the 536 node modules on npm that require a similar compilation and node-pre-gyp is the compiling bridge for each one. With the upcoming releases of bcrypt precompiled binaries for NodeJS 12 will be added for some OS/Architectures. If you are going to do development in general though, you should really add the build tools to avoid running into issues with many of the other packages out there as well. |
@YasharF you're right, i was trying to install npm in v12.8.1 and nothing worked. |
node --version:
v12.3.0
Ubuntu 18.04
Confirmed that it installs fine in mode
v12.2.0
The text was updated successfully, but these errors were encountered: