Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

util-inl.h missing #27803

Closed
marudor opened this issue May 21, 2019 · 4 comments
Closed

util-inl.h missing #27803

marudor opened this issue May 21, 2019 · 4 comments
Labels
addons Issues and PRs related to native addons. c++ Issues and PRs that require attention from people who are familiar with C++. confirmed-bug Issues with confirmed bugs.

Comments

@marudor
Copy link

marudor commented May 21, 2019

  • Version: v12.3.0
  • Platform: Darwin Kernel Version 18.6.0: Thu Apr 25 23:16:27 PDT 2019; root:xnu-4903.261.4~2/RELEASE_X86_64 x86_64
  • Subsystem:

node.h:107 now includes util-inl.h. That file is not shipped by node-gyp though.

12.2 did not include this file.
@addaleax addaleax added c++ Issues and PRs that require attention from people who are familiar with C++. confirmed-bug Issues with confirmed bugs. addons Issues and PRs related to native addons. labels May 21, 2019
addaleax added a commit to addaleax/node that referenced this issue May 21, 2019
@addaleax
src: remove util-inl.h include in node.h
3853b0c 
`node.h` may only include public APIs, which `util-inl.h` is not.
There does not seem to be any reason for including it, so remove it,
because otherwise native addon compilation is broken due to us not
shipping the `util-inl.h` header.

Refs: nodejs#27631
Fixes: nodejs#27803
@sam-github
Copy link
Contributor

I thought it had previously been indirectly included into our API, so added it in #27631 when it was removed from other core headers. I was mistaken, sorry.

@addaleax addaleax mentioned this issue May 21, 2019
Closed
2 tasks
@cjihrig cjihrig mentioned this issue May 22, 2019
Closed
BridgeAR pushed a commit that referenced this issue May 22, 2019
@addaleax @BridgeAR
src: remove util-inl.h include in node.h
7438a55 
`node.h` may only include public APIs, which `util-inl.h` is not.
There does not seem to be any reason for including it, so remove it,
because otherwise native addon compilation is broken due to us not
shipping the `util-inl.h` header.

Refs: #27631
Fixes: #27803

PR-URL: #27804
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@HarikrishnanBalagopal
Copy link

Why is this closed? I encountered the same bug when trying to install node-gyp. I am using the latest node version 12.3.0
err.txt

@fennih
Copy link

fennih commented May 22, 2019

In file included from ../../nan/nan.h:51:0, from ../src/node-boilerplate/scrypt_common.cc:28: /root/.node-gyp/12.3.0/include/node/node.h:107:24: fatal error: util-inl.h: No such file or directory compilation terminated.

Me too. Trying with "npm install" I get this error.

@cjihrig
Copy link
Contributor

cjihrig commented May 22, 2019

This issue is closed because the bug has been fixed on master. The fix will go out in a release later today. Please follow along with the release at #27814. Sorry for any confusion.

@richardlau richardlau mentioned this issue May 22, 2019
Closed
@Algunenano Algunenano mentioned this issue May 22, 2019
Merged
@dainis dainis mentioned this issue May 22, 2019
Closed
@mike-marcacci mike-marcacci mentioned this issue May 22, 2019
Closed
@felixhao28 felixhao28 mentioned this issue May 23, 2019
Closed
@ridhoq ridhoq mentioned this issue May 23, 2019
Closed
@nolanmar511 nolanmar511 mentioned this issue May 23, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
addons Issues and PRs related to native addons. c++ Issues and PRs that require attention from people who are familiar with C++. confirmed-bug Issues with confirmed bugs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

src: remove util-inl.h include in node.h addaleax/node
6 participants
@sam-github @addaleax @marudor @cjihrig @HarikrishnanBalagopal @fennih