Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix an issues with responding with long strings #576

Merged
merged 1 commit into from
Jul 8, 2020
Merged

Fix an issues with responding with long strings #576

merged 1 commit into from
Jul 8, 2020

Conversation

mamantoha
Copy link
Contributor

Fixes #575

This change works for me.

/cc @bcardiff maybe you can provide more information about this issue. Thanks.

@mamantoha mamantoha changed the title fix long response body Fix an issues with responding with long strings Jun 15, 2020
@nickbclifford
Copy link

Would love to see this merged, I'm currently blocked on upgrading to 0.35.0 by this exact problem.

@bcardiff
Copy link
Contributor

I think is needed because of the changes in https://github.com/crystal-lang/crystal/pull/9115/files .

The change seems good.

@mamantoha
Copy link
Contributor Author

@bcardiff there is another issue with WebSockets related to this changes in Crystal.

I created a fix in #577

@sdogruyol it would be nice if you will able to review both.

Thanks.

@xaviablaza
Copy link

This change works for me, would love to see this merged as it fixes static files infinitely loading on crystal 0.35.1.

@bcardiff bcardiff mentioned this pull request Jun 26, 2020
Closed
sdogruyol
sdogruyol approved these changes Jul 8, 2020
View reviewed changes
Copy link
Member

@sdogruyol sdogruyol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mamantoha 🙏

@sdogruyol sdogruyol merged commit 2e749a2 into kemalcr:master Jul 8, 2020
@mamantoha mamantoha mentioned this pull request Oct 16, 2020
Closed
@unixfox unixfox mentioned this pull request Jun 30, 2021
Merged
@mamantoha mamantoha deleted the fix-long-response-bodies branch October 25, 2022 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xaviablaza xaviablaza xaviablaza approved these changes

@yorci yorci yorci approved these changes

@sdogruyol sdogruyol sdogruyol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Kemal gets stuck for long response bodies
6 participants
@mamantoha @nickbclifford @bcardiff @xaviablaza @sdogruyol @yorci