Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix websocket issue #577

Merged
merged 2 commits into from
Jul 8, 2020
Merged

fix websocket issue #577

merged 2 commits into from
Jul 8, 2020

Conversation

mamantoha
Copy link
Contributor

There is another issue with Kemal in Crystal 0.35.0. Websockets are broken.
I create a repository where you can reproduce an issue https://github.com/mamantoha/kemal_websocket_issue

Run

crystal server.cr

Open http://localhost:3000

websocket_issue01

@xaviablaza
Copy link

Would love to see this merged into the upstream, thank you! @mamantoha

Co-authored-by: Sijawusz Pur Rahnama <sija@sija.pl>
@msa7
Copy link

msa7 commented Jun 23, 2020

What about merge it?

@drum445
Copy link

drum445 commented Jul 5, 2020

Any chance of this being merged/fixed? Whenever communication happens between the client and server, the socket DCs

Copy link
Member

@sdogruyol sdogruyol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mamantoha 🙏

@sdogruyol sdogruyol merged commit dfe7dca into kemalcr:master Jul 8, 2020
@mamantoha mamantoha deleted the fix-websocket-issue branch October 25, 2022 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants