Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added annex figures, tables, equations #738

Conversation

de-code
Copy link
Collaborator

@de-code de-code commented Apr 14, 2021

resolves #737

@de-code de-code requested review from lfoppiano and kermitt2 April 14, 2021 13:40
@de-code de-code self-assigned this Apr 14, 2021
@coveralls
Copy link

coveralls commented Apr 14, 2021

Coverage Status

Coverage increased (+0.006%) to 38.943% when pulling 6f45c06 on elifesciences:back-section-figure-tables-upstream into 4073084 on kermitt2:master.

@de-code de-code force-pushed the back-section-figure-tables-upstream branch from 3605866 to 6f45c06 Compare April 14, 2021 13:53
@de-code
Copy link
Collaborator Author

de-code commented Apr 14, 2021

I am not quite sure how I managed to increase the coverage without adding tests or deleting code.

@kermitt2 kermitt2 added the bug From Hemiptera and especially its suborder Heteroptera label Apr 14, 2021
@lfoppiano
Copy link
Collaborator

With the standard model, I cannot see any difference, the "Extended Data Figure 1" is not extracted at all in both cases.
I've checked the code and the PR looks good to me.

@de-code
Copy link
Collaborator Author

de-code commented May 13, 2021

I noticed one issue with it, is that the figure ids are reset. e.g. first body figure has the id fig_0. Then the first back section / annex figure also has the id fig_0.

@lfoppiano
Copy link
Collaborator

I close this, which is continued on #1215

@lfoppiano lfoppiano closed this Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug From Hemiptera and especially its suborder Heteroptera
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Figures and tables in the back / annex section ignored
4 participants