Make upcoming renaming of TrackerHit to TrackerHit3D transparent #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmadlener
force-pushed
the
trackerhit-interface
branch
from
5618d5b to
073cbfa
Compare
10 tasks
|
Main open question at this point: How smooth should the transition be and should there be some backwards compatibility for some time for older versions of EDM4hep? |
tmadlener
force-pushed
the
trackerhit-interface
branch
3 times, most recently
from
df1f33d to
b6e520a
Compare
tmadlener
changed the title
|
I decided to make the renaming and the addition of the actual conversion two PRs, because that is less of a Catch 22 situation of which PR needs to go in first and we can now let the EDM4hep one progress after this is merged. |
1 task
tmadlener
force-pushed
the
trackerhit-interface
branch
from
b6e520a to
b909895
Compare
|
Merging this to unblock the wrapper PR. All other necessary changes are in an tagged, so there should not be any problem here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
TrackerHit->TrackerHit3DtransparentENDRELEASENOTES
- [ ] Use interface types for TrackerHit EDM4hep#252(no longer needed)Putting the actual addition of converting all tracker hit into another PR as this will let us progress quicker with getting the EDM4hep changes merged.
@Zehvogel FYI