Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spec.version is required #819

Open
wants to merge 2 commits into
base: staging
Choose a base branch
from
Open

spec.version is required #819

wants to merge 2 commits into from

Conversation

jmazzitelli
Copy link
Contributor

@jmazzitelli jmazzitelli commented Sep 16, 2024 •
edited
Loading

@jmazzitelli jmazzitelli self-assigned this Sep 16, 2024
@jmazzitelli jmazzitelli mentioned this pull request Sep 16, 2024
Open
jshaughn
jshaughn requested changes Sep 16, 2024
View reviewed changes
content/en/docs/Installation/installation-guide/creating-updating-kiali-cr.md Outdated
Comment on lines 18 to 20
CR. You do, however, need to specify the version to install. Normally, you
can just set this to `default` which tells the Kiali Operator to install
the Kiali Server whose version is the same as that of the operator itself:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
CR. You do, however, need to specify the version to install. Normally, you
can just set this to `default` which tells the Kiali Operator to install
the Kiali Server whose version is the same as that of the operator itself:
CR. You do, however, need to specify the version to install. Normally, you
can just set this to `default` which tells the Kiali Operator to install the
Kiali Server whose version is the same as that of the operator itself. But, to
update the Kiali Operator while maintaining a fixed Kiali Server, you must
set the specific Kiali Server version.

You can re-word it, or maybe show the version format, but I think it would be good to be a little more elaborate here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-worded

jshaughn
jshaughn approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@jshaughn jshaughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jshaughn jshaughn jshaughn approved these changes

Assignees

@jmazzitelli jmazzitelli

Labels
None yet
Projects
Kiali Sprint 24-12 | Kiali v1.89.x
Status: 👀 In review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmazzitelli @jshaughn