Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make spec.version required in Kiali CR and OSSMConsole CR #7741

Open
jmazzitelli opened this issue Sep 12, 2024 · 2 comments · May be fixed by kiali/kiali-operator#818
Open

make spec.version required in Kiali CR and OSSMConsole CR #7741

jmazzitelli opened this issue Sep 12, 2024 · 2 comments · May be fixed by kiali/kiali-operator#818
Assignees
Labels
enhancement This is the preferred way to describe new end-to-end features. requires docs PR Requires kiali.io or other documentation updates requires helm chart PR requires operator PR It requires update in operator code

Comments

@jmazzitelli
Copy link
Collaborator

jmazzitelli commented Sep 12, 2024

Now that we have many versions of Kiali, and OSSMC and backstage plugins, and they support different versions of Istio and each other, confusion is rampant among users :)

This is because if spec.version is not specified in the CRs, a default version is selected by the operator, and that version might not be compatible with the user's Istio or other Kiali components.

We need to make spec.version required. If not specified, the operator should immediately fail, and put a good error message in the status field of the CR letting the user know what they have to do.

@jmazzitelli jmazzitelli added the enhancement This is the preferred way to describe new end-to-end features. label Sep 12, 2024
@jmazzitelli
Copy link
Collaborator Author

Note that we will still support the literal value default for spec.version (which we always have supported). This issue only concerns when there is no spec.version defined at all (it is completely missing from the Kiali CR).

jmazzitelli added a commit to jmazzitelli/kiali-operator that referenced this issue Sep 12, 2024
jmazzitelli added a commit to jmazzitelli/helm-charts that referenced this issue Sep 12, 2024
@jmazzitelli jmazzitelli self-assigned this Sep 12, 2024
jmazzitelli added a commit to jmazzitelli/kiali-operator that referenced this issue Sep 12, 2024
jmazzitelli added a commit to jmazzitelli/kiali-operator that referenced this issue Sep 13, 2024
jmazzitelli added a commit to jmazzitelli/kiali.io that referenced this issue Sep 16, 2024
jmazzitelli added a commit to jmazzitelli/kiali-operator that referenced this issue Sep 16, 2024
@jmazzitelli jmazzitelli added requires operator PR It requires update in operator code requires helm chart PR requires docs PR Requires kiali.io or other documentation updates labels Sep 16, 2024
@jmazzitelli
Copy link
Collaborator Author

@nrfox and @ferhoyos are -1 on fixing this.
I am +1.

We need more votes. Others, please chime in.

If we get a quorum and the consensus is to do nothing, I can close this issue and cancel the PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This is the preferred way to describe new end-to-end features. requires docs PR Requires kiali.io or other documentation updates requires helm chart PR requires operator PR It requires update in operator code
Projects
Status: 👀 In review
Development

Successfully merging a pull request may close this issue.

1 participant