-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Updated the counts-umi-smk rule and it's scripts to python3 #93
Merged
Ampholyt
merged 17 commits into
kircherlab:development
from
bioinformaticsguy:counts-umi-smk-script-update
Jan 24, 2024
Merged
refactor: Updated the counts-umi-smk rule and it's scripts to python3 #93
Ampholyt
merged 17 commits into
kircherlab:development
from
bioinformaticsguy:counts-umi-smk-script-update
Jan 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….py to update the script to python3.
…adsBAM_python3.py
…as it is needed in the FastQ2doubleIndexBAM_python3.py script.
File "/home/ali/Documents/MPRAsnakeflow/workflow/rules/../scripts/count/FastQ2doubleIndexBAM_python3.py", line 281, in <module> outfiles[None][0].write(forward) File "pysam/libcalignmentfile.pyx", line 1710, in pysam.libcalignmentfile.AlignmentFile.write File "pysam/libcalignmentfile.pyx", line 1742, in pysam.libcalignmentfile.AlignmentFile.write OSError: sam_write1 failed with error code -1 [E::bgzf_close] File write failed
Ampholyt
reviewed
Jan 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I add it here because it is a minor thing (actually because of the Snakefile): change regex strings in the Snakefile to raw strings as mentioned here
visze
pushed a commit
to visze/MPRAsnakeflow
that referenced
this pull request
Jul 31, 2024
…k-script-update refactor: Updated the counts-umi-smk rule and it's scripts to python3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created new files for scripts with the suffix _python3 and also added the pysam library in the python3 environment that was needed by the python scripts