Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make non public nodes public #363

Merged
merged 4 commits into from
Feb 2, 2024
Merged

Make non public nodes public #363

merged 4 commits into from
Feb 2, 2024

Conversation

mfontanini
Copy link
Contributor

@mfontanini mfontanini commented Jan 31, 2024

NodeMultilineBlockQuote and NodeShortCode are not exported anywhere in this crate.

@mfontanini mfontanini changed the title Make NodeMultilineBlockQuote public Make non public nodes public Jan 31, 2024
@digitalmoksha
Copy link
Collaborator

Hmm, it is public in src/parser/multiline_block_quote.rs - is that not enough? I see that NodeShortCode is handled in the same way.

@mfontanini
Copy link
Contributor Author

Right, the problem is that the parser module is not public . So you can have pub types in there but nothing is making them reachable publicly. I think it's fine that parser isn't pub, but any nodes defined within that module should be re-exported as pub in comrak::nodes like every other node type. You can see these aren't public in the docs, there's no way to see their definitions there.

@digitalmoksha
Copy link
Collaborator

Ah yeah, I see 👍

@kivikakk
Copy link
Owner

kivikakk commented Feb 2, 2024

LGTM! There's a little CI error because this now exposes some un-documented stuff; would you be able to address? Merge will happen automatically on CI success.

auto-merge was automatically disabled February 2, 2024 17:17

Head branch was pushed to by a user without write access

@gjtorikian gjtorikian merged commit 315a25c into kivikakk:main Feb 2, 2024
12 checks passed
@mfontanini mfontanini deleted the pub-multiline-block-quote branch February 2, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants