Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make non public nodes public #363

Merged
merged 4 commits into from
Feb 2, 2024
Merged

Make non public nodes public #363

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a1782b9
Make `NodeMultilineBlockQuote` public
mfontanini Jan 31, 2024
d7b9118
Make `NodeShortCode` public
mfontanini Jan 31, 2024
42e7b2b
Add missing docs to `NodeShortCode`.
mfontanini Feb 2, 2024
a356d40
Merge branch 'main' into pub-multiline-block-quote
mfontanini Feb 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/nodes.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,9 @@ use std::cell::RefCell;
use std::convert::TryFrom;

#[cfg(feature = "shortcodes")]
use crate::parser::shortcodes::NodeShortCode;
pub use crate::parser::shortcodes::NodeShortCode;

use crate::parser::multiline_block_quote::NodeMultilineBlockQuote;
pub use crate::parser::multiline_block_quote::NodeMultilineBlockQuote;

/// The core AST node enum.
#[derive(Debug, Clone, PartialEq, Eq)]
Expand Down
3 changes: 3 additions & 0 deletions src/parser/shortcodes.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,17 @@ pub struct NodeShortCode(
);

impl NodeShortCode {
/// Checks whether the input is a valid short code.
pub fn is_valid(value: &str) -> bool {
emojis::get_by_shortcode(value).is_some()
}

/// Get the underlying shortcode.
pub fn shortcode(&self) -> &str {
&self.0
}

/// Get the emoji for this short code.
pub fn emoji(&self) -> &'static str {
emojis::get_by_shortcode(&self.0).unwrap().as_str()
}
Expand Down
Loading