Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check uncheck tasks #27

Closed
matthiasdebernardini opened this issue Aug 1, 2018 · 1 comment
Closed

check uncheck tasks #27

matthiasdebernardini opened this issue Aug 1, 2018 · 1 comment
Labels
bug Something isn't working

Comments

@matthiasdebernardini
Copy link

Describe the bug
when you check an item that has already been checked the program returns item checked even though it actually becomes unchecked

To Reproduce
$ tb -t foo
$tb -c 1
$tb -c 1

Expected behavior
If I realized that what I had done wasn't actually done I would want to uncheck it so the program should return "# unchecked" if I run --check twice on an item

Screenshots
If applicable, add screenshots to help explain your problem.

Technical Info (please complete the following information)

  • OS: macOS (10.13.6)
  • Node.js Version: v8.11.3
  • Taskbook Version: 0.1.1

Additional context
Add any other context about the problem here.
@ashinzekene
Copy link
Contributor

I will create a pull request for this

@ashinzekene ashinzekene mentioned this issue Aug 4, 2018
Merged
@klaudiosinani klaudiosinani added the bug Something isn't working label Aug 7, 2018
klaudiosinani pushed a commit that referenced this issue Sep 2, 2018
@ashinzekene @klaudiosinani
Improved verbosity of check & star options. Fixes #27. (#51)
b6eca64 
* proper messages for unstarring and unchecking

* fixed linting errors

* resolved some issues

* used ternary in for loop

* added checks for empty id ary  for markIncomplete, markComplete, markStarred & markUnstarred methods.

* fixed ordering of checked and unchecked items
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@klaudiosinani @ashinzekene @matthiasdebernardini