Proper messages for unchecking and unstarring items

[ashinzekene]

Fixes #27

Shows the right message when unchecking and unstarring items. For example

✔  Unchecked tasks: 3, 1

[klaudiosinani]

It is possible to check if the ids array is empty from within the method, so we can directly call it later on, without having to wrap it inside an if statement:

  markIncomplete(ids) {
+  if (ids.length === 0) {
+    return;
+  }
  const [prefix, suffix] = ['\n', grey(ids.join(', '))];
  const message = `Unchecked ${ids.length > 1 ? 'tasks' : 'task'}:`;
  success({prefix, message, suffix});
}

The same can be done for the markComplete, markStarred & markUnstarred methods.

[rjoydip-zz]

I think this condition check is not necessary.

[markusberg-spt]

The if statement is necessary, @ashinzekene should add them

[klaudiosinani]

It is possible to group the assignments here, using destructuring, in order to keep the method as tidy as possible:

const [complete, incomplete] = [[], []];

[klaudiosinani]

Here we can go for a ternary operator as the conditional expression:

ids.forEach(id => {
   _data[id].isComplete = !_data[id].isComplete;
   return _data[id].isComplete ? complete.push(id) : incomplete.push(id);
});

[markusberg-spt]

This part has not been updated yet, i can help out if needed

[klaudiosinani]

The if statements can be dropped here, and directly call the methods:

 render.markComplete(complete);
 render.markIncomplete(incomplete);

[klaudiosinani]

For the same reasons mentioned above:

const [starred, unstarred] = [[], []];

[klaudiosinani]

ids.forEach(id => {
  _data[id].isStarred = !_data[id].isStarred;
  return _data[id].isStarred ? starred.push(id) : unstarred.push(id);
});

[markusberg-spt]

This part still hasnt been updated, please let me know if you need help, happy to contribute

[klaudiosinani]

render.markStarred(starred);
render.markUnstarred(unstarred);

[klaudiosinani]

Looks good! A couple of changes and it is good to go. Please, feel free to share your thoughts on the proposed modifications : )

[ashinzekene]

Sorry I have not replied in a while. I'm working on my undergraduate project and I'm far behind schedule.

[klaudiosinani]

It is completely Ok to avoid the camel-case here and go for unchecked as a variable name:

const [checked, unchecked] = [[], []];

[klaudiosinani]

Items whose isComplete attribute is updated to true should be placed in the checked array and items whose isComplete attribute is updated to false should be placed in the unchecked one:

return _data[id].isComplete ? checked.push(id) : unchecked.push(id);

[ashinzekene]

No. I think it is right this way. The line above has already changed the status of the tasks

[ashinzekene]

render.markIncomplete(checked);
and then this

[klaudiosinani]

The process you are describing is indeed identical, but these arrays, checked[] & unchecked[], are meant to store item IDs based on each item's updated isComplete attribute value, and not on the original/database-stored one, thus reversing them will lead to a clearer and more obvious behavior for future readers. For example: an item stored in the database with its isComplete attribute set to false (unchecked), once selected & checked by the user, will have its value updated to its opposite true (checked), thus its ID should be passed to the checked array. The same holds for the opposite case, where the item is initially marked as complete.

[klaudiosinani]

Checked items should be displayed before the unchecked ones, just like with the display of the starred/unstarred items on line 476:

 render.markComplete(checked);
 render.markIncomplete(unchecked);

[klaudiosinani]

The camel-case can be dropped here as well:

const [starred, unstarred] = [[], []];

[klaudiosinani]

return _data[id].isStarred ? starred.push(id) : unstarred.push(id);

[klaudiosinani]

render.markStarred(starred);
render.markUnstarred(unstarred);

[klaudiosinani]

Looks very good! A couple of minor updates and it is good to be merged : )

[ashinzekene]

I think we are good now

[klaudiosinani]

Looks great! Thank you a lot for taking the time to contribute : )