forked from cardano-foundation/CIPs
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add notes from workshop 1 + general details #1
Closed
Ryun1
wants to merge
20
commits into
klntsky:klntsky/query-layer-cps
from
Ryun1:query-layer-cps-workshop-1
Closed
Add notes from workshop 1 + general details #1
Ryun1
wants to merge
20
commits into
klntsky:klntsky/query-layer-cps
from
Ryun1:query-layer-cps-workshop-1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klntsky
requested changes
Feb 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! Especially the expanded use cases
Just a few notes though
klntsky
reviewed
Feb 5, 2024
Ryun1
commented
Feb 6, 2024
Ryun1
force-pushed
the
query-layer-cps-workshop-1
branch
from
March 6, 2024 13:51
00b9f73
to
da9c479
Compare
…o-foundation#612) * Specify hashing algorithm for rootHash calculation * Add off-chain version property * Update categories with Lace DApp Store category list * Add DApp screenshot and company detail fields * Remove duplicated/ambiguous website property * Add some property length constraints and describe image requirements * Specify property length limit for the rest `social` props * Fix a typo * Enhanced the regex for URLs to be more permissive by allowing ipfs and other protocols. Renamed twitter to x.com * Removed extra signature in the on-chain metadata * Applied suggestions to have flexible social links * Logo and screenshots gives you the posibility to add base64 images and changed version to follow semver * Added examples using the new schema * Follow semver for all versions * Removed optional links, images only via base64. Added 3 new fields * Changed some descriptions and added some mandatory fields * Added screenshots as mandatory * Removed ftp for links * Added short description to be mandatory * Applied suggestions after review * Bump version to 2.0.0 and removed schema topic in rationale * There is no point defining a schema if it can be violated 🤷 * Applied suggestion, we are not signing the off-chain data anymore. * URL settings simplified * Fixed version to follow semver --------- Co-authored-by: Daniel Main <daniel@funktional.dev> Co-authored-by: Daniel Main <daniel.main.cernhoff@icloud.com>
) * conway-keys CIP intial commit * add CC cold and hot keys * further details on CC keys * small correction * add CC to rationale * small tidy * fix extended key type naming, thanks @gitmachtl * missed _bip32 for CC hot key type * align with CIP number 105 * credentail serilisation correction * revert last crdential serilzation changes * clarification around credential array
Co-authored-by: fill-the-fill <fill.ickevics@gmail.com>
* Second draft of the governance metadata CIP * Typo * Small bits of feedback * Make open questions more discoverable * Assign CIP number 100 * Revision based on community feedback This implements the feedback from 2 separate community workshops, the recordings of which can be found here: - https://www.youtube.com/watch?v=X3XdQZx_TyU - https://www.youtube.com/watch?v=bBQMF6Dr6HY In particular, this limits the scope of what this CIP tries to achieve, and answers many of the open questions. There are still a few small items to finish off before we're ready to merge this. * Final draft for CIP-0100 Provides a JSON-LD and JSON Schema file for the minimal features. Reworks the wording of many bits, especially to reference a parallel CIP to extend CIP-0013. Renames "justification" to "comment", to leave it more general so others can specify the rationale-related extensions. Provides example test vectors. Folds the "augmentation" concept into a simple "references" field. * Update CIP-0100/README.md Co-authored-by: Ryan Williams <44342099+Ryun1@users.noreply.github.com> --------- Co-authored-by: Ryan Williams <44342099+Ryun1@users.noreply.github.com>
* Add first draft of the on-chain token policy registration CIP. * qualify pull request discussion URL Co-authored-by: Ryan Williams <44342099+Ryun1@users.noreply.github.com> * correct anchor for CIP-0036 URL Co-authored-by: Ryan Williams <44342099+Ryun1@users.noreply.github.com> * reformat license to standard CIP form Co-authored-by: Ryan Williams <44342099+Ryun1@users.noreply.github.com> * Add proposed CIP-26 Fungible Token registration along with examples and schema documentation. * Minor formatting changes for CIP-26 README.md as well as first draft specification for CIP-25/68 NFT Metadata standards. * Minor updates to the URI Array schema definition and adding CIP-25 support documentation. * Update CIP-XXXX/README.md Co-authored-by: Matthias Benkort <5680256+KtorZ@users.noreply.github.com> * Update directory structure to use proposed CIP cardano-foundation#88 and add 867 metadatum label to the CIP-10 registry. * Update CIP Title * **CIP-0088: Token Policy Registration** Updates to README.md based on feedback of CIP editors and community. * **CIP-0088: Token Policy Registration** - Add v1.0.0 CDDL spec - Update primary README.md file to use updated CBOR CDDL notation for examples as well as enhance display formatting and examples. * **CIP-0088: Token Policy Registration** - Update readme to address issues and questions presented by CPS-0001 - Update CDDL to support a more flexible scoping structure for future expansion * Update CIP-0088/README.md Co-authored-by: Robert Phair <rphair@cosd.com> * Update CIP-0088/README.md Co-authored-by: Robert Phair <rphair@cosd.com> * **CIP-0088: Token Policy Registration** - Update for preliminary support for CIP-48 (Metadata References) - Updates to make the validation method a UInt format index of well-defined methods for validation - Clean-up of some of the CBOR examples * **CIP-0088: Registration Certificates** - Minor typo fix * **CIP-0088: Registration Certificates** - Fix typo in discussions link * **CIP-0088: Registration Certificates** - Rename and split CDDL files to better support dynamic versioning and iteration of CIP-Specific details in the future. * - Add NFT Project Details CDDL and Specification Details * Correct minor capitalization issue in NFT-Project-Details.md * Some minor changes to CDDL specs and building out a better directory structure. * Updates to CIP-88: - Complete restructuring of CIP-Specific Documentation - Provide context for when, where, and how to create extensions and modifications to the CIP - Improve documentation and optimize some data structures - Switch to Unsigned Integer version numbers for maximum on-chain compatibility - Finalize v1 documentation for most of the specification so that work on publication and validation can begin. This version should be approaching readiness to begin testing the publication and validation of information on testnet to confirm that all data structures work as expected. * Fix YAML header * Update CIP-0088/README.md Co-authored-by: Robert Phair <rphair@cosd.com> * Update Native Script scope Updated examples to include Native Script scope and also included some updates to examples and other documentation to ensure consistency. --------- Co-authored-by: Robert Phair <rphair@cosd.com> Co-authored-by: Ryan Williams <44342099+Ryun1@users.noreply.github.com> Co-authored-by: Matthias Benkort <5680256+KtorZ@users.noreply.github.com>
* CIP-????: POO Protocol Initial Commit/PR * Update with relevant links to the PR * Fix YAML format * Fix YAML format * Rollback changes to the CIP-13 README.md and add to the Proof of Onboarding README.md and update name and other clarifications per feedback. Also fixed in-file JSON errors that were causing problems. * Minor update to document progress on acceptance criteria and implementation actions taken in July 2023. * Update examples to properly reflect that the API server should return the tokens array with hex-encoded asset names and not ASCII asset names. * Remove Version 2 for now as it is unnecessary at this time, let's keep it simple for the sake of early adoption. * Fix minor typo in an example * fix header level * fix header level * fix header level * fix header level * fix header level * fix header level * fix header level * fix header level * fix header level * fix header level * fix header level * fix header level * fix header level * fix header level * fix header level * fix header level * fix header level * fix header level * fix header level * fix header level * fix header level * fix header level * fix header level * fix header level * fix header level * fix header level * fix header level * fix header level * fix header level * fix header level * fix header level * fix header level * fix header level * fix header level & add explicit section title * fix header level * fix header level * fix header level * fix header level * Update CIP-XXXX/README.md * fixed glitch from edit during CIP meeting * Update CIP-XXXX/README.md Co-authored-by: Ryan Williams <44342099+Ryun1@users.noreply.github.com> * Update CIP-XXXX/README.md Co-authored-by: Ryan Williams <44342099+Ryun1@users.noreply.github.com> * Changes to CIP-99: * Language edits, additions, and modifications to bring the document in line with community and editor feedback. * Addition of explicit versioning and modification criteria * Updates to the implementation plan and acceptance criteria for CIP-99 * Update CIP-99 to active status --------- Co-authored-by: Robert Phair <rphair@cosd.com> Co-authored-by: Ryan Williams <44342099+Ryun1@users.noreply.github.com>
…foundation#637) * candidacies and merges from CIP meeting 78 * also promoted cardano-foundation#632
Co-authored-by: Vladimir Kalnitsky <klntsky@gmail.com>
Co-authored-by: Vladimir Kalnitsky <klntsky@gmail.com>
Ryun1
force-pushed
the
query-layer-cps-workshop-1
branch
from
March 6, 2024 13:53
da9c479
to
4ddbedf
Compare
Messed up the git history, so opened a new PR #2 |
klntsky
pushed a commit
that referenced
this pull request
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.