dont have default since it might not exist #858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gordon-klotho
approved these changes
Jan 11, 2024
| @@ -22,7 +22,7 @@ properties: | |||
| security group rule | |||
| SecurityGroupId: | |||
| type: string # Not resource type because we need deploy time properties to be able to exist here | |||
| default_value: '{{ upstream "aws:security_group" .Self }}#Id' | |||
| required: true | |||
There was a problem hiding this comment.
Should this also be namespaced to the SG?
There was a problem hiding this comment.
this has to be a string value so i dont think namespace fits too too well since we expect it to be a resource. And in some cases the SG wont exist in our graph either
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #851
we cant rely on a default here, for eks case the cluster security group doesnt exist in our graph, but is what we create a rule against so it just needs to be set. Making the field required should ensure it always has a value
Standard checks