Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dont have default since it might not exist #858

Merged
merged 1 commit into from
Jan 11, 2024
Merged

dont have default since it might not exist #858

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/templates/aws/resources/security_group_rule.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ properties:
security group rule
SecurityGroupId:
type: string # Not resource type because we need deploy time properties to be able to exist here
default_value: '{{ upstream "aws:security_group" .Self }}#Id'
required: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this also be namespaced to the SG?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this has to be a string value so i dont think namespace fits too too well since we expect it to be a resource. And in some cases the SG wont exist in our graph either

description: The ID of the security group to which this rule should be attached
Type:
type: string
Expand Down
Loading