-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[data-plane] Receiver: Reject unauthorized requests #4043
Comments
/help |
@creydr: Please ensure the request meets the requirements listed here. If this request no longer meets these requirements, the label can be removed In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/area data-plane |
Putting back in "Draft" status, as this maybe could be included in #4042 already |
We need to verify in the receiver (ingress), that an request is authorized. Therefor we should do the following in the receiver:
.status.policies
is set:EventPolicies
(in their.status.from[]
).403
status code.status.policies
is empty:default-authorization-mode
and do the following depending on its value:allow-all
: Continue with the requestdeny-all
: reject the request with a403
status codeallow-same-namespace
: check, if the senders identity is from the same namespace, as the resource. If so, continue with the request, otherwise reject with a403
We should also add an e2e test for the above scenarios.
Additional context:
Additional hints for new contributors before starting with this issue:
Draft
status, the issue is subject to change and thus should not be started to be worked on/assign
). Please be aware that we might unassign you, if we don't see any progress from your side to give other contributors also a chance to work on this issue.The text was updated successfully, but these errors were encountered: